Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: replace Set.prototype by SetPrototype primordials #31161

Closed

Conversation

@Sebastien-Ahkrin
Copy link
Contributor

Sebastien-Ahkrin commented Jan 2, 2020

Hello 馃槃

Just replaced every Set.prototype by SetPrototype in the lib/* folder
For this, i just have added SetPrototype in the import

const {
  // [...]
  SetPrototype,
} = primordials;

I hope this pull request will help you ! :P

@Sebastien-Ahkrin

This comment has been minimized.

Copy link
Contributor Author

Sebastien-Ahkrin commented Jan 2, 2020

Refs: #30697

@cjihrig
cjihrig approved these changes Jan 2, 2020
@targos
targos approved these changes Jan 2, 2020
@nodejs-github-bot

This comment has been minimized.

@jasnell
jasnell approved these changes Jan 2, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Jan 3, 2020

@Trott
Trott approved these changes Jan 4, 2020
@trivikr
trivikr approved these changes Jan 4, 2020
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 4, 2020

Landed in e568403

@Trott Trott closed this Jan 4, 2020
Trott added a commit that referenced this pull request Jan 4, 2020
PR-URL: #31161
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Jan 6, 2020
PR-URL: #31161
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #31161
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Micha毛l Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can鈥檛 perform that action at this time.