Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
module: expose exports conditions to loaders #31303
bmeck left a comment
I really like this PR! This falls into some things we are starting to see from the community about custom conditions like https://twitter.com/sebmarkbage/status/1234223477424447488 .
There's one C++ test that seems to fail on linuxone. I look into it briefly but I don't see a clear reason why it would fail (or what the failure really means). I'm surprised that this PR would affect low-level worker interactions but can't rule it out.
* Remove import of URL & process as they are unnecessary * Update bare-import check to match language used in error * Improve accuracy of hook's thrown error message * Improve accuracy of parameter & return type annotations * Remove unncessary async keyword in hook functions * Add missing conditions property to resolve hook types * Incorporate relevant findings into documentation Refs: nodejs#31303 Fixes: nodejs#29610
* Add JSDoc typings to function boundaries * Remove import of URL & process as they are unnecessary * Update bare-specifier check to match language used in error * Improve accuracy of hook's thrown error message * Move destructuring assignment of default to within function Refs: nodejs#31303