Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: async iterator improvements #31316

Closed
wants to merge 5 commits into from

Conversation

@ronag
Copy link
Member

ronag commented Jan 11, 2020

Includes a few different fixes separated into commits:

  • Adds support to create async iterators from v1 streams.
  • Normalize destroying non conforming streams.
  • Implement throw on the iterator.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Jan 11, 2020

ping @addaleax

lib/internal/streams/async_iterator.js Outdated Show resolved Hide resolved
@ronag ronag force-pushed the nxtedition:stream-async-iterator branch 2 times, most recently Jan 11, 2020
@ronag ronag changed the title stream: add async iterator support for v1 streams stream: async iterator fixes Jan 11, 2020
@ronag ronag force-pushed the nxtedition:stream-async-iterator branch 6 times, most recently Jan 11, 2020
@ronag ronag changed the title stream: async iterator fixes stream: async iterator improvements Jan 11, 2020
@ronag ronag force-pushed the nxtedition:stream-async-iterator branch Jan 11, 2020
lib/internal/streams/async_iterator.js Show resolved Hide resolved
test/parallel/test-stream-readable-async-iterators.js Outdated Show resolved Hide resolved
@ronag ronag force-pushed the nxtedition:stream-async-iterator branch 2 times, most recently Jan 12, 2020
lib/internal/streams/legacy.js Outdated Show resolved Hide resolved
@ronag ronag force-pushed the nxtedition:stream-async-iterator branch 2 times, most recently Jan 12, 2020
@nodejs-github-bot

This comment has been minimized.

Copy link
Member

mcollina left a comment

lgtm

lib/internal/streams/async_iterator.js Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment was marked as outdated.

@Trott
Trott approved these changes Jan 13, 2020
@nodejs-github-bot

This comment was marked as outdated.

ronag added a commit that referenced this pull request Jan 26, 2020
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
ronag added a commit that referenced this pull request Jan 26, 2020
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
ronag added a commit that referenced this pull request Jan 26, 2020
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
ronag added a commit that referenced this pull request Jan 26, 2020
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Jan 26, 2020

Landed in 97ac661...07915db

@ronag ronag closed this Jan 26, 2020
codebytere added a commit that referenced this pull request Feb 17, 2020
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
codebytere added a commit that referenced this pull request Feb 17, 2020
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
codebytere added a commit that referenced this pull request Feb 17, 2020
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Feb 29, 2020

@ronag the last two commits in this PR need manual backports

@MylesBorins MylesBorins mentioned this pull request Mar 9, 2020
7 of 7 tasks complete
@ronag ronag mentioned this pull request Mar 10, 2020
4 of 4 tasks complete
ronag added a commit to nxtedition/node that referenced this pull request Mar 10, 2020
PR-URL: nodejs#31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Backport-PR-URL: nodejs#32174
ronag added a commit to nxtedition/node that referenced this pull request Mar 10, 2020
PR-URL: nodejs#31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Backport-PR-URL: nodejs#32174
MylesBorins added a commit that referenced this pull request Mar 10, 2020
Backport-PR-URL: #32174
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
MylesBorins added a commit that referenced this pull request Mar 10, 2020
Backport-PR-URL: #32174
PR-URL: #31316
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Mar 15, 2020

@ronag should this go to v12.x, and if yes, can you open a manual backport? Given the recent issues on v13.x i'd like to play it safe so feel free to update the label to don't-land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.