Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 7.0.0-alpha.2 #31400

Closed
wants to merge 5 commits into from
Closed

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Jan 17, 2020

Update ESLint to 7.0.0-alpha.2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 17, 2020

Is the idea that this won't land until 7.0.0 is out and the PR will be updated to include that?

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

cjihrig commented Jan 17, 2020

Is the idea that this won't land until 7.0.0 is out and the PR will be updated to include that?

I'm fine with that approach. FWIW, in the past, we have updated to ESLint alpha releases as well.

Copy link
Member

BridgeAR left a comment

RSLGTM

Landing the updates incrementally allows us to adjust everything during the individual release and we could already use the changed features. The eslints changes are normally very stable, no matter that it's an alpha. I am fine with waiting or landing it right away therefore.

Copy link
Member

trivikr left a comment

RSLGTM

@Trott
Trott approved these changes Jan 21, 2020
@cjihrig cjihrig force-pushed the cjihrig:eslint branch Feb 15, 2020
@cjihrig cjihrig changed the title tools: update ESLint to 7.0.0-alpha.0 tools: update ESLint to 7.0.0-alpha.1 Feb 15, 2020
cjihrig added 5 commits Feb 28, 2020
Update ESLint to 7.0.0-alpha.0
Update ESLint to 7.0.0-alpha.1
Update ESLint to 7.0.0-alpha.2
@cjihrig cjihrig force-pushed the cjihrig:eslint branch to 0bc8fe0 Feb 28, 2020
@cjihrig cjihrig changed the title tools: update ESLint to 7.0.0-alpha.1 tools: update ESLint to 7.0.0-alpha.2 Feb 28, 2020
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Mar 9, 2020

addaleax added a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax added a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Mar 11, 2020

Landed in 61f28fb...4f87b4f

addaleax added a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax added a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax addaleax closed this Mar 11, 2020
addaleax added a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig deleted the cjihrig:eslint branch Mar 11, 2020
MylesBorins added a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Mar 11, 2020
Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Mar 11, 2020
PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.