Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove dead code in InternalMakeCallback #31622

Conversation

@Flarna
Copy link
Member

Flarna commented Feb 3, 2020

Remove unneeded condition as the first line in function already ensures that recv can't be empty.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Remove unneeded condition as the first line in function already
ensures that recv can't be empty.
@jasnell
jasnell approved these changes Feb 3, 2020
@cjihrig
cjihrig approved these changes Feb 3, 2020
@lpinca
lpinca approved these changes Feb 3, 2020
@yhwang
yhwang approved these changes Feb 5, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

addaleax added a commit that referenced this pull request Feb 8, 2020
Remove unneeded condition as the first line in function already
ensures that recv can't be empty.

PR-URL: #31622
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yihong Wang <yh.wang@ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Feb 8, 2020

Landed in 7a63d76

@addaleax addaleax closed this Feb 8, 2020
@Flarna Flarna deleted the dynatrace-oss-contrib:remove-dead-code-callbackscope branch Feb 8, 2020
codebytere added a commit that referenced this pull request Feb 17, 2020
Remove unneeded condition as the first line in function already
ensures that recv can't be empty.

PR-URL: #31622
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yihong Wang <yh.wang@ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.