fix #31650 right use of string and bytes objects #31659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
i18n-api
addaleax
added
the
python
|
@nodejs/python |
addaleax
reviewed
Feb 7, 2020
bnoordhuis
reviewed
Feb 8, 2020
bioinfornatics
force-pushed
the
icutrim
branch
from
8e9b724
to
4c49c50
Compare
aqrln
reviewed
Feb 27, 2020
cclauss
requested changes
Feb 27, 2020
cclauss
reviewed
Feb 27, 2020
cclauss
approved these changes
Feb 27, 2020
bioinfornatics
changed the title
|
Thanks everybody for your help! 👍 |
|
@nodejs/python |
sam-github
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
RSLGTM. Note to landers... the PR will need to be squashed and the commit message rewritten to match the commit guidelines: https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
@bioinfornatics you can rebase, squash, fix the message, and force-push the branch yourself, or if you aren't comfortable with that, it can be done during landing.
bnoordhuis
approved these changes
Mar 5, 2020
|
LGTM. I'm currently carrying this patch in Fedora to allow building on systems with no python2. |
jasnell
pushed a commit
that referenced
this pull request
Mar 18, 2020
PR-URL: #31659 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in a squashed commit 5f0af2a |
|
@bioinfornatics and team, thanks for your perseverance on this one... It is good that it has landed. |
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Mar 19, 2020
PR-URL: #31659 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
PR-URL: #31659 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #31659 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #31650
Checklist
[ x]
make -j4 test(UNIX), orvcbuild test(Windows) passes[x ] commit message follows commit guidelines