Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updates fishrock123 #31725

Closed

Conversation

@Fishrock123
Copy link
Member

Fishrock123 commented Feb 10, 2020

It was a good run. Almost 5 years.

I haven't really been involved in the last 3+? months though, so it's time I call it and 'retire' from the TSC.

I think it is unlikely that I'll be on the TSC again, as node is unfortunately becoming increasingly disinteresting (& frustrating) to me.

Also moves me to a past releaser, as I haven't done any in the past 1-2 year(s) I don't really plan on doing more.

(So long and thanks for all the fish!)

(I am aware there is a list of other access that will need to be cleaned up...)

Checklist
Fishrock123 added 3 commits Feb 10, 2020
I have not done a release in well over a year, maybe even two.

I also don't really plan to do more, as Node.js releases are very tedious.
It was a good run. Almost 5 years.

I haven't really been involved in the last 3+? months though, so it's time I call it and 'retire'.

I think it is unlikely that I'll be on the TSC again, as node is unfortunately becoming increasingly disinteresting (& frustrating) to me.

(So long and thanks for all the fish!)
might as well while I'm at it

feels a bit weird being the first person on this list with '/they' but I guess someone's gota do it
* **Jeremiah Senkpiel** <fishrock@keybase.io>
`FD3A5288F042B6850C66B31F09FE44734EB7990E`
Comment on lines +580 to +581

This comment has been minimized.

Copy link
@richardlau

richardlau Feb 10, 2020

Member

Keep this alphabetically sorted?

Copy link
Contributor

cjihrig left a comment

Thanks for everything!

Copy link
Member

mhdawson left a comment

LGTM

@danbev
danbev approved these changes Feb 13, 2020
@gireeshpunathil gireeshpunathil mentioned this pull request Feb 13, 2020
3 of 4 tasks complete
Copy link
Member

mcollina left a comment

lgtm

@jasnell

This comment has been minimized.

Copy link
Member

jasnell commented Feb 13, 2020

@Fishrock123 ... hopefully you'll stick around and contribute every now and then but even if not, it's been a pleasure working with you on the project the past few years

@mcollina

This comment has been minimized.

Copy link
Member

mcollina commented Feb 13, 2020

It has been an absolute pleasure work with you Jeremiah!

Copy link
Member

MylesBorins left a comment

Thanks for the hard work Jeremiah

@gireeshpunathil

This comment has been minimized.

gireeshpunathil added a commit that referenced this pull request Feb 17, 2020
I have not done a release in well over a year, maybe even two.

I also don't really plan to do more,
as Node.js releases are very tedious.

PR-URL: #31725
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gireeshpunathil added a commit that referenced this pull request Feb 17, 2020
It was a good run. Almost 5 years.

I haven't really been involved in the last 3+? months though,
so it's time I call it and 'retire'.

I think it is unlikely that I'll be on the TSC again,
as node is unfortunately becoming increasingly
disinteresting (& frustrating) to me.

(So long and thanks for all the fish!)

PR-URL: #31725
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gireeshpunathil added a commit that referenced this pull request Feb 17, 2020
might as well while I'm at it

feels a bit weird being the first person on this list
with '/they' but I guess someone's gota do it

PR-URL: #31725
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Feb 17, 2020

landed in 4d6c861...30e6049

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Feb 17, 2020

I've taken care of all the items listed at https://github.com/nodejs/TSC/blob/master/ONBOARDING.md#offboarding with the exception of the HackerOne stuff. I don't have access to https://hackerone.com/nodejs/team_members and can't seem to remove Jeremiah and Gireesh from the group. /ping @sam-github

Note that by "taken care of", I mean in a few cases that I opened a pull request, but the pull requests still need to be merged:

@mhdawson

This comment has been minimized.

Copy link
Member

mhdawson commented Feb 17, 2020

@Trott thanks. Merged those 2 PRs.

@Fishrock123 Fishrock123 deleted the Fishrock123:readme-updates-fishrock123 branch Feb 17, 2020
@Fishrock123

This comment has been minimized.

Copy link
Member Author

Fishrock123 commented Feb 17, 2020

Cheers everyone.

For what it's worth I never made an account with HackerOne.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.