Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.x] module: self resolve flag as experimental modules #31757

Closed

Conversation

@guybedford
Copy link
Contributor

guybedford commented Feb 12, 2020

Resolves #31754.

Ensure package self resolution remains behind --experimental-modules.

//cc @nodejs/modules-active-members @MylesBorins

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@guybedford guybedford force-pushed the guybedford:flag-self-resolve branch from 1c38997 to 052e1a9 Feb 12, 2020
@guybedford guybedford changed the title module: 12.x self resolve flag as experimental modules [12.x] module: self resolve flag as experimental modules Feb 12, 2020
@ljharb
ljharb approved these changes Feb 12, 2020
Copy link
Member

ljharb left a comment

Thanks! (edit: oops, i'm not a collaborator; ignore the green color on this checkmark)

@jkrems

This comment has been minimized.

Copy link
Contributor

jkrems commented Feb 12, 2020

Should the base branch be changed to v12.x-staging? See: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#how-are-lts-branches-managed

@jkrems
jkrems approved these changes Feb 12, 2020
@guybedford guybedford changed the base branch from v12.x to v12.x-staging Feb 13, 2020
Copy link
Member

MylesBorins left a comment

LGTM

I'll try and get something together this afternoon

MylesBorins added a commit that referenced this pull request Feb 13, 2020
PR-URL: #31757
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Feb 13, 2020

landed in f0b2d87

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Feb 13, 2020

Seems like the commit was missing the "resolves" stanza that auto-closes the linked issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.