Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_hooks: ensure event after been emitted on runInAsyncScope #31784

Closed
wants to merge 1 commit into from

Conversation

@legendecas
Copy link
Member

legendecas commented Feb 14, 2020

Also removes a duplicated case test-emit-after-uncaught-exception-runInAsyncScope.js
which is identical to test-emit-after-uncaught-exception.js.

The exception handler user-defined will not automatically emit after for the async resource.

Fixes: #31783
Related: #30965

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@legendecas legendecas force-pushed the legendecas:async-run-throws branch 2 times, most recently Feb 14, 2020
The exception handler user-defined will not automatically emit after
for the async resource.

Also removes a duplicated case
`test-emit-after-uncaught-exception-runInAsyncScope.js`
which is identical to test-emit-after-uncaught-exception.js.
@legendecas legendecas force-pushed the legendecas:async-run-throws branch to 942fcc7 Feb 14, 2020
@MylesBorins MylesBorins requested a review from apapirovski Feb 14, 2020
@nodejs-github-bot

This comment has been minimized.

@addaleax addaleax mentioned this pull request Feb 14, 2020
Copy link
Member

addaleax left a comment

Can we please fast-track this in order to get a proper commit from master into #31781 (v12.16.1)?

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Feb 14, 2020

Landed in 75311db

@addaleax addaleax closed this Feb 14, 2020
addaleax added a commit that referenced this pull request Feb 14, 2020
The exception handler user-defined will not automatically emit after
for the async resource.

Also removes a duplicated case
`test-emit-after-uncaught-exception-runInAsyncScope.js`
which is identical to test-emit-after-uncaught-exception.js.

Refs: #30965
PR-URL: #31784
Fixes: #31783
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@legendecas legendecas deleted the legendecas:async-run-throws branch Feb 14, 2020
addaleax added a commit that referenced this pull request Feb 14, 2020
The exception handler user-defined will not automatically emit after
for the async resource.

Also removes a duplicated case
`test-emit-after-uncaught-exception-runInAsyncScope.js`
which is identical to test-emit-after-uncaught-exception.js.

Refs: #30965
PR-URL: #31784
Fixes: #31783
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere added a commit that referenced this pull request Feb 17, 2020
The exception handler user-defined will not automatically emit after
for the async resource.

Also removes a duplicated case
`test-emit-after-uncaught-exception-runInAsyncScope.js`
which is identical to test-emit-after-uncaught-exception.js.

Refs: #30965
PR-URL: #31784
Fixes: #31783
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.