Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve doc/markdown file organization coherence #31792

Closed
wants to merge 10 commits into from

Conversation

@ConorDavenport
Copy link
Contributor

ConorDavenport commented Feb 14, 2020

Improve markdown and documentation file organization.

Fixes: #31741

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
README.md Outdated Show resolved Hide resolved
@jasnell jasnell requested a review from sam-github Feb 14, 2020
@sam-github

This comment has been minimized.

Copy link
Member

sam-github commented Feb 14, 2020

What happened to #31771 ? In the futre, please don't create duplicate PRs, its confusing, and loses the conversation history.

Copy link
Member

sam-github left a comment

A couple small suggestions. Please do not close this branch or the PR. Make any changes you need to locally, and force push the branch to update the PR. Thanks!

benchmark/README.md Outdated Show resolved Hide resolved
doc/guides/contributing/pull-requests.md Outdated Show resolved Hide resolved
@jasnell

This comment has been minimized.

Copy link
Member

jasnell commented Feb 14, 2020

What happened to #31771 ? In the futre, please don't create duplicate PRs, its confusing, and loses the conversation history.

@sam-github ... yeah, @ConorDavenport is still getting the hang of git ;-) ... we'll get him sorted on that soon!

GOVERNANCE.md Outdated Show resolved Hide resolved
ConorDavenport and others added 10 commits Feb 14, 2020
Updated cpp style guide file name and location and fixed links to
this file.

Fixes: #31741
Updated collaborator guide file name and location and fixed links
to this file.

Fixes: #31741
Updated documentation style guide file name and location and updated
links referencing the file.

Fixes: #31741
Fixed the links referencing markdown files that have moved location

Fixes: #31741
Moved files to appropriate location and updated naming style for
some of them.

Fixes: #31741
Reduced line length for linter
Co-Authored-By: James M Snell <jasnell@gmail.com>
@ConorDavenport ConorDavenport force-pushed the ConorDavenport:issue31741 branch to bec8a74 Feb 27, 2020
@sam-github

This comment has been minimized.

Copy link
Member

sam-github commented Mar 2, 2020

Thanks @ConorDavenport , I kicked off a ci-lite, then it should be landable.

@sam-github

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Mar 4, 2020

Landed in bf7409e

@addaleax addaleax closed this Mar 4, 2020
addaleax added a commit that referenced this pull request Mar 4, 2020
* Updated cpp style guide file name and location and fixed links to
  this file.

* Updated collaborator guide file name and location and fixed links
  to this file.

* Updated documentation style guide file name and location and updated
  links referencing the file.

* Moved files to appropriate location and updated naming style for
  some of them.

Fixes: #31741

PR-URL: #31792
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins added a commit that referenced this pull request Mar 4, 2020
* Updated cpp style guide file name and location and fixed links to
  this file.

* Updated collaborator guide file name and location and fixed links
  to this file.

* Updated documentation style guide file name and location and updated
  links referencing the file.

* Moved files to appropriate location and updated naming style for
  some of them.

Fixes: #31741

PR-URL: #31792
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 4, 2020
codebytere added a commit that referenced this pull request Mar 16, 2020
* Updated cpp style guide file name and location and fixed links to
  this file.

* Updated collaborator guide file name and location and fixed links
  to this file.

* Updated documentation style guide file name and location and updated
  links referencing the file.

* Moved files to appropriate location and updated naming style for
  some of them.

Fixes: #31741

PR-URL: #31792
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
codebytere added a commit that referenced this pull request Mar 17, 2020
* Updated cpp style guide file name and location and fixed links to
  this file.

* Updated collaborator guide file name and location and fixed links
  to this file.

* Updated documentation style guide file name and location and updated
  links referencing the file.

* Moved files to appropriate location and updated naming style for
  some of them.

Fixes: #31741

PR-URL: #31792
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
codebytere added a commit that referenced this pull request Mar 23, 2020
* Updated cpp style guide file name and location and fixed links to
  this file.

* Updated collaborator guide file name and location and fixed links
  to this file.

* Updated documentation style guide file name and location and updated
  links referencing the file.

* Moved files to appropriate location and updated naming style for
  some of them.

Fixes: #31741

PR-URL: #31792
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
codebytere added a commit that referenced this pull request Mar 30, 2020
* Updated cpp style guide file name and location and fixed links to
  this file.

* Updated collaborator guide file name and location and fixed links
  to this file.

* Updated documentation style guide file name and location and updated
  links referencing the file.

* Moved files to appropriate location and updated naming style for
  some of them.

Fixes: #31741

PR-URL: #31792
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.