Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add zlib maintenance doc #31800

Closed
wants to merge 3 commits into from
Closed

Conversation

@sam-github
Copy link
Member

sam-github commented Feb 14, 2020

Add a maintenance doc for deps/zlib, and run the process.

Result is an almost entirely empty "update" (only the mode of one file was different from upstream).

Note: we changed to using a google repo as upstream in #31201

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@sam-github sam-github requested a review from mscdex Feb 14, 2020
@sam-github sam-github mentioned this pull request Feb 14, 2020
3 of 3 tasks complete
doc/guides/maintaining-zlib.md Outdated Show resolved Hide resolved
doc/guides/maintaining-zlib.md Outdated Show resolved Hide resolved
@sam-github sam-github force-pushed the sam-github:update-zlib branch Feb 18, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

sam-github added 3 commits Feb 14, 2020
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.
Updated as described in doc/guides/maintaining-zlib.md.
@sam-github sam-github force-pushed the sam-github:update-zlib branch to f70ebe6 Feb 18, 2020
@nodejs-github-bot

This comment has been minimized.

@sam-github

This comment has been minimized.

Copy link
Member Author

sam-github commented Feb 24, 2020

Landed in b70dd9d...9a1719b

@sam-github sam-github closed this Feb 24, 2020
sam-github added a commit that referenced this pull request Feb 24, 2020
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
sam-github added a commit that referenced this pull request Feb 24, 2020
See:
- #31201

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
sam-github added a commit that referenced this pull request Feb 24, 2020
Updated as described in doc/guides/maintaining-zlib.md.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@sam-github sam-github deleted the sam-github:update-zlib branch Feb 24, 2020
codebytere added a commit that referenced this pull request Feb 27, 2020
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere added a commit that referenced this pull request Feb 27, 2020
See:
- #31201

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere added a commit that referenced this pull request Feb 27, 2020
Updated as described in doc/guides/maintaining-zlib.md.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
codebytere added a commit that referenced this pull request Mar 15, 2020
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere added a commit that referenced this pull request Mar 15, 2020
See:
- #31201

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere added a commit that referenced this pull request Mar 15, 2020
Updated as described in doc/guides/maintaining-zlib.md.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere added a commit that referenced this pull request Mar 17, 2020
deps/zlib/README.md is not part of the upstream zlib, it is a Node.js
specific addition describing how to maintain zlib and should be in
doc/guides/.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere added a commit that referenced this pull request Mar 17, 2020
See:
- #31201

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere added a commit that referenced this pull request Mar 17, 2020
Updated as described in doc/guides/maintaining-zlib.md.

PR-URL: #31800
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.