Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: convert errorMonitor to normal property #31848

Closed

Conversation

@Flarna
Copy link
Member

Flarna commented Feb 18, 2020

Convert property errorMonitor to a normal property as non-writable caused unwanted side effects.

Refs: #30932 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
lib/events.js Show resolved Hide resolved
Convert property errorMonitor to a normal property as non-writable
caused unwanted side effects.

Refs: #30932 (comment)
@Flarna Flarna force-pushed the dynatrace-oss-contrib:events-error-monitor branch to e00a3fb Feb 18, 2020
@Flarna Flarna changed the title events: convert errorMonitor to getter events: convert errorMonitor to normal property Feb 21, 2020
@targos
targos approved these changes Feb 21, 2020
@Flarna Flarna mentioned this pull request Feb 21, 2020
4 of 4 tasks complete
@lpinca
lpinca approved these changes Feb 21, 2020
@Flarna

This comment has been minimized.

Copy link
Member Author

Flarna commented Feb 25, 2020

Friendly ping, would be nice if someone could move this forward.

@nodejs-github-bot

This comment has been minimized.

@Flarna

This comment has been minimized.

Copy link
Member Author

Flarna commented Feb 28, 2020

Is there anything I can do for CI? I haven't found a way yet to retrigger it...

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Flarna

This comment has been minimized.

Copy link
Member Author

Flarna commented Mar 2, 2020

Is there something I can do for CI? Does it help if I rebase?

@mmarchini

This comment has been minimized.

Copy link
Member

mmarchini commented Mar 2, 2020

I'll land this, the only failure is

08:29:22 not ok 650 known_issues/test-vm-timeout-escape-queuemicrotask
08:29:22   ---
08:29:22   duration_ms: 1.242
08:29:22   severity: fail
08:29:22   stack: |-
08:29:22   ...

which is a known flaky (#32048) and won't be fixed (#31980).

mmarchini added a commit that referenced this pull request Mar 2, 2020
Convert property errorMonitor to a normal property as non-writable
caused unwanted side effects.

Refs: #30932 (comment)

PR-URL: #31848
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mmarchini

This comment has been minimized.

Copy link
Member

mmarchini commented Mar 2, 2020

Landed in ed8007a

@mmarchini mmarchini closed this Mar 2, 2020
@Flarna Flarna deleted the dynatrace-oss-contrib:events-error-monitor branch Mar 2, 2020
MylesBorins added a commit that referenced this pull request Mar 4, 2020
Convert property errorMonitor to a normal property as non-writable
caused unwanted side effects.

Refs: #30932 (comment)

PR-URL: #31848
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
You can’t perform that action at this time.