Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgram: make UDPWrap more reusable #31871

Closed
wants to merge 2 commits into from
Closed

Conversation

@jasnell
Copy link
Member

jasnell commented Feb 19, 2020

Authored by @addaleax and originally landed in the QUIC repo. Separating out from the QUIC PR. While this does not have any QUIC specific bits, QUIC would be the only current use of it so it would likely be best to land this PR in conjunction with the QUIC PR. Separating out only to make it easier to review.

Allow using the handle more directly for I/O in other parts of the codebase.

Original review metadata:

  PR-URL: https://github.com/nodejs/quic/pull/165
  Reviewed-By: James M Snell <jasnell@gmail.com>
  Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
lib/dgram.js Show resolved Hide resolved
src/udp_wrap.cc Outdated Show resolved Hide resolved
src/udp_wrap.cc Show resolved Hide resolved
src/udp_wrap.cc Outdated Show resolved Hide resolved
@jasnell

This comment has been minimized.

Copy link
Member Author

jasnell commented Feb 24, 2020

@addaleax ... given that you wrote the original change here, do you have thoughts on the suggestions from @mscdex and @bnoordhuis ?

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Feb 24, 2020

@jasnell Feel free to address Ben’s comments (or if you want, I can do that later this evening)

@jasnell jasnell requested review from addaleax and bnoordhuis Feb 26, 2020
@jasnell

This comment has been minimized.

Copy link
Member Author

jasnell commented Feb 29, 2020

Waiting for #31960 to land then will rebase this and update it to incorporate those changes.

@jasnell jasnell force-pushed the jasnell:reusable-udpwrap branch Mar 2, 2020
@jasnell

This comment has been minimized.

Copy link
Member Author

jasnell commented Mar 2, 2020

Rebased now that #31960 landed. @bnoordhuis and @addaleax, please take another look

src/udp_wrap.h Outdated Show resolved Hide resolved
@jasnell jasnell added the author ready label Mar 2, 2020
@nodejs-github-bot

This comment has been minimized.

Allow using the handle more directly for I/O in other parts of
the codebase.

Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#165
  Reviewed-By: James M Snell <jasnell@gmail.com>
  Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
```

Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell force-pushed the jasnell:reusable-udpwrap branch to 347ea10 Mar 2, 2020
@nodejs-github-bot

This comment has been minimized.

jasnell added a commit that referenced this pull request Mar 3, 2020
Allow using the handle more directly for I/O in other parts of
the codebase.

Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#165
  Reviewed-By: James M Snell <jasnell@gmail.com>
  Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
```

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31871
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jasnell

This comment has been minimized.

Copy link
Member Author

jasnell commented Mar 3, 2020

Landed in 43b7142

@jasnell jasnell closed this Mar 3, 2020
MylesBorins added a commit that referenced this pull request Mar 4, 2020
Allow using the handle more directly for I/O in other parts of
the codebase.

Originally landed in the QUIC repo

Original review metadata:

```
  PR-URL: nodejs/quic#165
  Reviewed-By: James M Snell <jasnell@gmail.com>
  Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
```

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31871
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.