Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win: block running on EOL Windows versions #31954

Closed

Conversation

@joaocgreis
Copy link
Member

joaocgreis commented Feb 25, 2020

Node.js v14 is being released after Windows 7/2008R2 reached EOL. This blocks Node from running in these OSs (and also Windows 8, long due) since changes are no longer tested there.

Using EOL Windows versions is discouraged, we offer no guarantees that Node.js works correctly. The last Node.js versions tested on Windows 7/2008R2 are 10.18.1, 12.14.1 and 13.6.0. This does not block major Node.js versions up to 13 from running on EOL Windows as it's probably better to use a later version, even if untested (since there are no breaking changes).

Refs: nodejs/build#2168
Refs: #5167

cc @nodejs/platform-windows @nodejs/build

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Windows 7 and Windows Server 2008 R2 EOL was January 14, 2020.
Windows 8 EOL was January 12, 2016.

Windows 2012 (not R2) is still supported and allowed to run. This
clarifies that support is experimental.
@nodejs-github-bot

This comment has been minimized.

@rvagg
rvagg approved these changes Feb 26, 2020
@Trott
Trott approved these changes Feb 26, 2020
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Feb 27, 2020

/ping @nodejs/tsc This is semver-major but hopefully uncontroversial.

@bnb

This comment has been minimized.

Copy link
Member

bnb commented Feb 27, 2020

🎉

Copy link
Member

mcollina left a comment

lgtm

@mattgresham

This comment has been minimized.

Copy link

mattgresham commented Feb 27, 2020

Just to confirm, that means no Windows Embedded POSReady 7 support? - https://support.microsoft.com/en-au/lifecycle/search?alpha=Windows%20Embedded%20POSReady%207

@joaocgreis

This comment has been minimized.

Copy link
Member Author

joaocgreis commented Feb 28, 2020

@mattgresham that is correct.

We don't have that Windows edition available for testing in our CI, so we can't support it.

Note that both Node.js v10 and v12 will be supported until after that edition reaches EOL, so both are good choices if you need to use Node there. We won't test new releases of v10 and v12 on Windows 7, but if anything breaks I would welcome a PR to fix. This is not likely to happen, as changes in v10 and v12 should be small and we still test on Windows 2012 and above.

@mattgresham

This comment has been minimized.

Copy link

mattgresham commented Mar 1, 2020

Thanks for your reply and info @joaocgreis. I'll pay a bit more attention to the Electron release notes and our POSReady 7 regression testing from now on then.

joaocgreis added a commit that referenced this pull request Mar 5, 2020
Windows 7 and Windows Server 2008 R2 EOL was January 14, 2020.
Windows 8 EOL was January 12, 2016.

Windows 2012 (not R2) is still supported and allowed to run. This
clarifies that support is experimental.

PR-URL: #31954
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@joaocgreis

This comment has been minimized.

Copy link
Member Author

joaocgreis commented Mar 5, 2020

Landed in cb8898c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.