Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add GC test for disabled AsyncLocalStorage #31995

Closed
wants to merge 1 commit into from

Conversation

@puzpuzpuz
Copy link
Contributor

puzpuzpuz commented Feb 28, 2020

Adds a GC test for AsyncLocalStorage to verify behavior described in the docs.

cc @vdeturckheim @Qard @Flarna

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Feb 28, 2020

Fast-track? It adds a relatively straightforward new test.

@Qard
Qard approved these changes Feb 28, 2020
@nodejs-github-bot

This comment has been minimized.

@Flarna
Flarna approved these changes Feb 28, 2020
@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Feb 28, 2020

Looks like tests are flaky. As far as I can see, failed tests are not related with this PR.

@nodejs-github-bot

This comment has been minimized.

@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Mar 2, 2020

Another flaky CI run 😢. Could someone re-run it?

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@puzpuzpuz puzpuzpuz force-pushed the puzpuzpuz:async-storage-gcable-test branch to e4f1c18 Mar 2, 2020
@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Mar 2, 2020

I have rebased over the latest master. Maybe those flaky tests are fixed and it would help CI build to pass.

@nodejs-github-bot

This comment has been minimized.

@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Mar 2, 2020

Another flaky CI run here.

@jasnell
jasnell approved these changes Mar 2, 2020
@nodejs-github-bot

This comment has been minimized.

@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Mar 2, 2020

Looks like this one is ready to land.

Copy link
Member

mhdawson left a comment

LGTM

@mhdawson

This comment has been minimized.

Copy link
Member

mhdawson commented Mar 2, 2020

Landing now

mhdawson added a commit that referenced this pull request Mar 2, 2020
PR-URL: #31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson

This comment has been minimized.

Copy link
Member

mhdawson commented Mar 2, 2020

Landed as 96e70c4

@mhdawson mhdawson closed this Mar 2, 2020
@puzpuzpuz puzpuzpuz deleted the puzpuzpuz:async-storage-gcable-test branch Mar 3, 2020
MylesBorins added a commit that referenced this pull request Mar 4, 2020
PR-URL: #31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 4, 2020
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Mar 16, 2020

Blocked on #26540.

puzpuzpuz added a commit to puzpuzpuz/node that referenced this pull request Mar 17, 2020
PR-URL: nodejs#31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Mar 17, 2020

v12 backport: #32318

puzpuzpuz added a commit to puzpuzpuz/node that referenced this pull request Apr 2, 2020
PR-URL: nodejs#31995
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.