From 26b929c8a62b1270625aab36bae9dd999a9f4f91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Tue, 29 Oct 2019 08:28:28 +0100 Subject: [PATCH 1/2] build: enable backtrace when V8 is built for PPC and S390x Refs: https://github.com/nodejs/node-v8/issues/119 --- common.gypi | 3 +++ tools/make-v8.sh | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index a867e925945ce4..9d554b7b8005da 100644 --- a/common.gypi +++ b/common.gypi @@ -102,6 +102,9 @@ 'obj_dir%': '<(PRODUCT_DIR)/obj.target', 'v8_base': '<(PRODUCT_DIR)/libv8_snapshot.a', }], + ['target_arch in ("ppc64", "s390x")', { + 'v8_enable_backtrace': 1, + }], ], }, diff --git a/tools/make-v8.sh b/tools/make-v8.sh index 37bc57f4994fb0..e4024330b169db 100755 --- a/tools/make-v8.sh +++ b/tools/make-v8.sh @@ -28,7 +28,7 @@ if [[ "$ARCH" == "s390x" ]] || [[ "$ARCH" == "ppc64le" ]]; then g++ --version gcc --version export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config - gn gen -v out.gn/$BUILD_ARCH_TYPE --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\"" + gn gen -v out.gn/$BUILD_ARCH_TYPE --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true" ninja -v -C out.gn/$BUILD_ARCH_TYPE d8 cctest inspector-test else PATH=~/_depot_tools:$PATH tools/dev/v8gen.py $BUILD_ARCH_TYPE --no-goma $V8_BUILD_OPTIONS From a2254ea87cee3f28174ee184041b598e4964efbd Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Fri, 6 Mar 2020 11:43:55 -0800 Subject: [PATCH 2/2] fixup! build: enable backtrace when V8 is built for PPC and S390x Co-Authored-By: Ben Noordhuis --- common.gypi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index 9d554b7b8005da..6488241b3c6601 100644 --- a/common.gypi +++ b/common.gypi @@ -102,7 +102,7 @@ 'obj_dir%': '<(PRODUCT_DIR)/obj.target', 'v8_base': '<(PRODUCT_DIR)/libv8_snapshot.a', }], - ['target_arch in ("ppc64", "s390x")', { + ['target_arch in "ppc64 s390x"', { 'v8_enable_backtrace': 1, }], ],