Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix compiler warnings #32126

Merged
merged 2 commits into from Mar 8, 2020
Merged

src: fix compiler warnings #32126

merged 2 commits into from Mar 8, 2020

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Mar 6, 2020

Refs: #32069

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Copy link
Member

mhdawson left a comment

LGTM

@lpinca
lpinca approved these changes Mar 6, 2020
@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Mar 6, 2020

cjihrig added 2 commits Mar 6, 2020
../src/node_http_common.h:497:8: warning: 'MemoryInfo' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
  void MemoryInfo(MemoryTracker* tracker) const {

PR-URL: #32126
Refs: #32069
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
../src/node_http_common-inl.h:126:7: warning: field 'token_'
will be initialized after field 'name_' [-Wreorder]
    : token_(other.token_),

PR-URL: #32126
Refs: #32069
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@cjihrig cjihrig force-pushed the cjihrig:warnings branch to 7bb4f95 Mar 8, 2020
@cjihrig cjihrig merged commit 7bb4f95 into nodejs:master Mar 8, 2020
14 of 16 checks passed
14 of 16 checks passed
build-docs
Details
build-docs
Details
build (3.8)
Details
build (3.8)
Details
ubuntu-build ubuntu-build
Details
ubuntu-build ubuntu-build
Details
build-linux
Details
build-windows
Details
build-macOS
Details
lint-addon-docs
Details
lint-cpp
Details
lint-md
Details
lint-js
Details
Travis CI - Pull Request Build Errored
Details
Travis CI - Pull Request Build Created
Details
Travis CI - Branch Build Passed
Details
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

cjihrig commented Mar 8, 2020

Landed in 99e5725...7bb4f95.

@cjihrig cjihrig deleted the cjihrig:warnings branch Mar 8, 2020
MylesBorins added a commit that referenced this pull request Mar 9, 2020
../src/node_http_common.h:497:8: warning: 'MemoryInfo' overrides a
member function but is not marked 'override' [-Winconsistent-missing-override]
  void MemoryInfo(MemoryTracker* tracker) const {

PR-URL: #32126
Refs: #32069
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins added a commit that referenced this pull request Mar 9, 2020
../src/node_http_common-inl.h:126:7: warning: field 'token_'
will be initialized after field 'name_' [-Wreorder]
    : token_(other.token_),

PR-URL: #32126
Refs: #32069
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Mar 16, 2020

This is blocked for v12.x pending landing of #32069.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
You can’t perform that action at this time.