Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix test-fs-read-stream-fd-leak race cond #3218

Closed
wants to merge 1 commit into from

Conversation

@john-yan
Copy link
Contributor

commented Oct 6, 2015

Fix problem #3215 by redo checking for openCount in slow running environment.

@mhdawson mhdawson self-assigned this Oct 6, 2015

@john-yan john-yan force-pushed the john-yan:fix-test-fd-leak branch to a47311f Oct 6, 2015

@john-yan john-yan changed the title Fix test-fs-read-stream-fd-leak race condition by checking multiple t… test: Fix test-fs-read-stream-fd-leak race cond Oct 6, 2015

@mscdex mscdex added the fs label Oct 6, 2015

@mhdawson

This comment has been minimized.

Copy link

commented on a47311f Oct 7, 2015

This looks good to me ltgm.

I'll pull in unless somebody raises objections in the next few days

@jasnell

This comment has been minimized.

Copy link
Member

commented Oct 7, 2015

LGTM

@mhdawson

This comment has been minimized.

Copy link
Member

commented Oct 8, 2015

@mhdawson

This comment has been minimized.

Copy link
Member

commented Oct 8, 2015

CI run looks good

mhdawson added a commit that referenced this pull request Oct 8, 2015
test: Fix test-fs-read-stream-fd-leak race cond
Fix intermittent test failure on slower machines.
Gives test longer time to complete but checks
at regular intervals so that the test only
runs longer on slower machines or in the failure
case.

PR-URL: #3218
Fixes: #3215
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James Snell <jasnell@gmail.com>>
@mhdawson

This comment has been minimized.

Copy link
Member

commented Oct 8, 2015

landed as 8aa589c

@mhdawson

This comment has been minimized.

Copy link
Member

commented Oct 8, 2015

Will leave open until it gets pulled into 4.X

jasnell added a commit that referenced this pull request Oct 8, 2015
test: Fix test-fs-read-stream-fd-leak race cond
Fix intermittent test failure on slower machines.
Gives test longer time to complete but checks
at regular intervals so that the test only
runs longer on slower machines or in the failure
case.

PR-URL: #3218
Fixes: #3215
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James Snell <jasnell@gmail.com>>
@jasnell

This comment has been minimized.

Copy link
Member

commented Oct 8, 2015

Landed in v4.x with 7c85557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.