Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020-04-21, Version 14.0.0 (Current) #32181

Draft
wants to merge 1 commit into
base: master
from
Draft

2020-04-21, Version 14.0.0 (Current) #32181

wants to merge 1 commit into from

Conversation

@BethGriggs
Copy link
Member

BethGriggs commented Mar 10, 2020

2020-04-21, Version 14.0.0 (Current), @BethGriggs

Notable Changes

  • TBD

Semver-Major Commits

  • [9b6e797379] - (SEMVER-MAJOR) Revert "assert: fix line number calculation after V8 upgrade" (Michaël Zasso) #32116
  • [5360dd151d] - (SEMVER-MAJOR) assert: handle (deep) equal(NaN, NaN) as being identical (Ruben Bridgewater) #30766
  • [6a349019da] - (SEMVER-MAJOR) build: temporarily skip ASAN build (Matheus Marchini) #32116
  • [da92f15413] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Matheus Marchini) #32116
  • [e65bed1b7e] - (SEMVER-MAJOR) child_process: create proper public API for channel (Anna Henningsen) #30165
  • [1b9a62cff4] - (SEMVER-MAJOR) crypto: make DH error messages consistent (Tobias Nießen) #31873
  • [bffa5044c5] - (SEMVER-MAJOR) crypto: move pbkdf2 without digest to EOL (James M Snell) #31166
  • [10f5fa7513] - (SEMVER-MAJOR) crypto: forbid setting the PBKDF2 iter count to 0 (Tobias Nießen) #30578
  • [1cd235d1a0] - (SEMVER-MAJOR) deps: patch V8 to run on Xcode 8 (Matheus Marchini) #32116
  • [5d867badd0] - (SEMVER-MAJOR) deps: V8: silence irrelevant warnings (Michaël Zasso) #32116
  • [8d2c441e4d] - (SEMVER-MAJOR) deps: V8: cherry-pick 931bdbd76f5b (Matheus Marchini) #32116
  • [049160dfb6] - (SEMVER-MAJOR) deps: V8: cherry-pick 1e36e21acc40 (Matheus Marchini) #32116
  • [0220c298c5] - (SEMVER-MAJOR) deps: bump minimum icu version to 65 (Michaël Zasso) #32116
  • [f90eba1d91] - (SEMVER-MAJOR) deps: make v8.h compatible with VS2015 (Joao Reis) #32116
  • [56b6a4f732] - (SEMVER-MAJOR) deps: V8: forward declaration of Rtl\*FunctionTable (Refael Ackermann) #32116
  • [40c9419b35] - (SEMVER-MAJOR) deps: V8: patch register-arm64.h (Refael Ackermann) #32116
  • [55407ab73e] - (SEMVER-MAJOR) deps: patch V8 to run on older XCode versions (Ujjwal Sharma) #32116
  • [990bc9adb4] - (SEMVER-MAJOR) deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #32116
  • [17a6def4e8] - (SEMVER-MAJOR) deps: update V8 dtrace & postmortem metadata (cjihrig) #32116
  • [2883c855e0] - (SEMVER-MAJOR) deps: update V8 to 8.1.307.20 (Matheus Marchini) #32116
  • [1b2e2944bc] - (SEMVER-MAJOR) dgram: don't hide implicit bind errors (cjihrig) #31958
  • [afe353061b] - (SEMVER-MAJOR) doc: fs.write is not longer coercing strings (Juan José Arboleda) #31030
  • [4455f60320] - (SEMVER-MAJOR) doc: use shorter fs.copyFile examples (Ruben Bridgewater) #27044
  • [a45c1aa39f] - (SEMVER-MAJOR) doc: fix mode and flags being mistaken in fs (Ruben Bridgewater) #27044
  • [331d636240] - (SEMVER-MAJOR) errors: remove unused ERR_SOCKET_CANNOT_SEND error (cjihrig) #31958
  • [b8e41774d4] - (SEMVER-MAJOR) fs: add fs/promises alias module (Gus Caplan) #31553
  • [fb6df3bfac] - (SEMVER-MAJOR) fs: validate the input data to be of expected types (Ruben Bridgewater) #31030
  • [2d8febceef] - (SEMVER-MAJOR) fs: deprecate closing FileHandle on garbage collection (James M Snell) #28396
  • [67e067eb06] - (SEMVER-MAJOR) fs: watch signals for recursive incompatibility (Eran Levin) #29947
  • [f0d2df41f8] - (SEMVER-MAJOR) fs: change streams to always emit close by default (Robert Nagy) #31408
  • [a13500f503] - (SEMVER-MAJOR) fs: improve mode and flags validation (Ruben Bridgewater) #27044
  • [535e9571f5] - (SEMVER-MAJOR) fs: make FSStatWatcher.start private (Lucas Holmquist) #29971
  • [c1b2f6afbe] - (SEMVER-MAJOR) http: detach socket from IncomingMessage on keep-alive (Robert Nagy) #32153
  • [173d044d09] - (SEMVER-MAJOR) http: align OutgoingMessage and ClientRequest destroy (Robert Nagy) #32148
  • [d3715c76b5] - (SEMVER-MAJOR) http: move OutboundMessage.prototype.flush to EOL (James M Snell) #31164
  • [c776a37791] - (SEMVER-MAJOR) http: end with data can cause write after end (Robert Nagy) #28666
  • [ff2ed3ec85] - (SEMVER-MAJOR) http: remove unused hasItems() from freelist (Rich Trott) #30744
  • [d247a8e1dc] - (SEMVER-MAJOR) http: emit close on socket re-use (Robert Nagy) #28685
  • [6f0ec79e42] - (SEMVER-MAJOR) http,stream: make virtual methods throw an error (Luigi Pinca) #31912
  • [ec0dd6fa1c] - (SEMVER-MAJOR) lib: move GLOBAL and root aliases to EOL (James M Snell) #31167
  • [d7452b7140] - (SEMVER-MAJOR) module: warn on using unfinished circular dependency (Anna Henningsen) #29935
  • [eeccd52b4e] - (SEMVER-MAJOR) net: make readable/writable start as true (Robert Nagy) #32272
  • [ab4115f17c] - (SEMVER-MAJOR) os: move tmpDir() to EOL (James M Snell) #31169
  • [8c18e91c8a] - (SEMVER-MAJOR) process: remove undocumented now argument from emitWarning() (Rich Trott) #31643
  • [84c426cb60] - (SEMVER-MAJOR) repl: properly handle repl.repl (Ruben Bridgewater) #30981
  • [d19a2c33b3] - (SEMVER-MAJOR) src: migrate measureMemory to new v8 api (gengjiawen) #32116
  • [a63db7fb5e] - (SEMVER-MAJOR) src: remove deprecated wasm type check (Clemens Backes) #32116
  • [c080b2d821] - (SEMVER-MAJOR) src: avoid calling deprecated method (Clemens Backes) #32116
  • [7ed0d1439e] - (SEMVER-MAJOR) src: remove use of deprecated Symbol::Name() (cjihrig) #32116
  • [59eeb3b5b9] - (SEMVER-MAJOR) src: stop overriding deprecated V8 methods (Clemens Backes) #32116
  • [339c192ddb] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 83 (Matheus Marchini) #32116
  • [4f523c2c1a] - (SEMVER-MAJOR) src: migrate to new V8 ArrayBuffer API (Thang Tran) #30782
  • [c712fb7cd6] - (SEMVER-MAJOR) src: add abstract IsolatePlatformDelegate (Marcel Laverdet) #30324
  • [7cafd5f3a9] - (SEMVER-MAJOR) stream: fix finished w/ 'close' before 'end' (Robert Nagy) #31545
  • [311e12b962] - (SEMVER-MAJOR) stream: fix multiple destroy calls (Robert Nagy) #29197
  • [1f209129c7] - (SEMVER-MAJOR) stream: throw invalid argument errors (Robert Nagy) #31831
  • [d016b9d708] - (SEMVER-MAJOR) stream: finished callback for closed streams (Robert Nagy) #31509
  • [e559842188] - (SEMVER-MAJOR) stream: make readable & writable computed (Robert Nagy) #31197
  • [907c07fa85] - (SEMVER-MAJOR) stream: move _writableState.buffer to EOL (James M Snell) #31165
  • [66f4e4edcb] - (SEMVER-MAJOR) stream: do not emit 'end' after 'error' (Robert Nagy) #31182
  • [75b30c606c] - (SEMVER-MAJOR) stream: emit 'error' asynchronously (Robert Nagy) #29744
  • [4bec6d13f9] - (SEMVER-MAJOR) stream: enable autoDestroy by default (Robert Nagy) #30623
  • [20d009d2fd] - (SEMVER-MAJOR) stream: pipe should not swallow error (Robert Nagy) #30993
  • [67ed526ab0] - (SEMVER-MAJOR) stream: error state cleanup (Robert Nagy) #30851
  • [e902fadc5e] - (SEMVER-MAJOR) stream: do not throw multiple callback errors in writable (Robert Nagy) #30614
  • [e13a37e49d] - (SEMVER-MAJOR) stream: ensure finish is emitted in next tick (Robert Nagy) #30733
  • [9d09969f4c] - (SEMVER-MAJOR) stream: always invoke end callback (Robert Nagy) #29747
  • [52944b834a] - (SEMVER-MAJOR) test: remove test (Clemens Backes) #32116
  • [119fdf6813] - (SEMVER-MAJOR) test: remove checks for deserializing wasm (Matheus Marchini) #32116
  • [405ae1909b] - (SEMVER-MAJOR) tools: update V8 gypfiles for 8.1 (Matheus Marchini) #32116
  • [0f78dcc86d] - (SEMVER-MAJOR) util: escape C1 control characters and switch to hex format (Ruben Bridgewater) #29826
  • [cb8898c48f] - (SEMVER-MAJOR) win: block running on EOL Windows versions (João Reis) #31954
  • [a9401439c7] - (SEMVER-MAJOR) zlib: align with streams (Robert Nagy) #32220
@nodejs-github-bot

This comment has been minimized.

@jasnell

This comment has been minimized.

Copy link
Member

jasnell commented Mar 10, 2020

What is the semver major cutoff date?

@BethGriggs

This comment has been minimized.

Copy link
Member Author

BethGriggs commented Mar 10, 2020

@jasnell, I think Tuesday 24th March would be appropriate (that's rounding the 1 month we've followed previously down to 4 weeks, which does mean it will fall on a weekday rather than weekend).

@jasnell

This comment has been minimized.

Copy link
Member

jasnell commented Mar 10, 2020

Ok! That's perfect I think

@ronag

This comment has been minimized.

Copy link
Member

ronag commented Mar 10, 2020

I would like to request that we try to land #29656 before the cutoff date if possible.

Though I can see there are already quite a lot of semver major stream stuff so I would understand if we push this another semver major.

@ronkorving

This comment has been minimized.

Copy link
Contributor

ronkorving commented Mar 11, 2020

(SEMVER-MAJOR) deps: update V8 to 7.9.317.20 (Michaël Zasso)

Node 13 is already on 7.9.317.25-node.29 though?

@jasnell

This comment has been minimized.

Copy link
Member

jasnell commented Mar 11, 2020

So you know, I would love to get the QUIC PR landed before the cut off date. It would still be behind the --experimental-quic compile flag so would not be enabled by default in the distribution.

@BethGriggs

This comment has been minimized.

Copy link
Member Author

BethGriggs commented Mar 11, 2020

@ronag, our wording is:

One month or less before the release date, commits must be cherry-picked into the two branches. To land SEMVER-MAJOR at this time requires no objections from the TSC.

which gives us some flexibility :)

@ronkorving, thanks - that made it in there as the PR has the label semver-major but it has since been backported to v13.x. I will remove the entry in the next update - there are probably a couple of other PRs that need removing too.

@bricss

This comment has been minimized.

Copy link

bricss commented Mar 13, 2020

Please someone tell me that V8 8.1 will be pre-baked in it 🍰 🙄

BethGriggs added a commit that referenced this pull request Mar 17, 2020
Notable changes:

- TBD

PR-URL: #32181
@BethGriggs BethGriggs force-pushed the v14.x-proposal branch from e03c0c9 to e941e3f Mar 17, 2020
@nodejs-github-bot

This comment has been minimized.

@BethGriggs

This comment has been minimized.

Copy link
Member Author

BethGriggs commented Mar 17, 2020

@BethGriggs

This comment has been minimized.

Copy link
Member Author

BethGriggs commented Mar 18, 2020

BethGriggs added a commit that referenced this pull request Mar 25, 2020
Notable changes:

- TBD

PR-URL: #32181
@BethGriggs BethGriggs force-pushed the v14.x-proposal branch from e941e3f to 8088457 Mar 25, 2020
BethGriggs added a commit that referenced this pull request Mar 25, 2020
Notable changes:

- TBD

PR-URL: #32181
@BethGriggs BethGriggs force-pushed the v14.x-proposal branch from 8088457 to 6b76573 Mar 25, 2020
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Mar 26, 2020

@BethGriggs :

Request to incorporate 2fa74e3 into this release

  • addresses the only known bug in report
  • helps stable usage in the field
  • not a semver-major
@BethGriggs

This comment has been minimized.

Copy link
Member Author

BethGriggs commented Mar 26, 2020

@gireeshpunathil, as 2fa74e3 is a minor it will most likely appear in a current release of v13.x first, so it will not be called out in the v14.x changelog. Each week for the next 2-3 weeks i'll be picking all the non-major commits that land on master into the v14.x branch, so this commit will be in the v14.x release line.

Notable changes:

- TBD

PR-URL: #32181
@BethGriggs BethGriggs force-pushed the v14.x-proposal branch from 6b76573 to 42ce0b0 Mar 30, 2020
@nodejs-github-bot

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.