Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use Promise.all() in test-hash-seed #32273

Closed
wants to merge 0 commits into from
Closed

Conversation

@Trott
Copy link
Member

Trott commented Mar 14, 2020

We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Mar 15, 2020

@targos
targos approved these changes Mar 15, 2020
@Trott Trott added the author ready label Mar 15, 2020
test/pummel/test-hash-seed.js Outdated Show resolved Hide resolved
test/pummel/test-hash-seed.js Outdated Show resolved Hide resolved
test/pummel/test-hash-seed.js Outdated Show resolved Hide resolved
test/pummel/test-hash-seed.js Outdated Show resolved Hide resolved
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Mar 17, 2020

Copy link
Contributor

antsmartian left a comment

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Mar 18, 2020
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

PR-URL: nodejs#32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Mar 18, 2020

Landed in 1a3c747

@Trott Trott closed this Mar 18, 2020
@Trott Trott force-pushed the Trott:pummel-hash-seed branch to 1a3c747 Mar 18, 2020
@Trott Trott deleted the Trott:pummel-hash-seed branch Mar 18, 2020
MylesBorins added a commit that referenced this pull request Mar 19, 2020
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

PR-URL: #32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
MylesBorins added a commit that referenced this pull request Mar 24, 2020
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

PR-URL: #32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.