Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,crypto: clarify oaepHash option's impact #32340

Closed
wants to merge 1 commit into from

Conversation

@panva
Copy link
Contributor

panva commented Mar 18, 2020

Introduced in #28335 this option also applies the hash function to MGF1, not just OAEP. This doc update makes that clear.

@panva panva force-pushed the panva:crypto-docs-update branch Mar 19, 2020
@panva panva force-pushed the panva:crypto-docs-update branch to d823572 Mar 21, 2020
@panva

This comment has been minimized.

Copy link
Contributor Author

panva commented Mar 21, 2020

Can't do much about the failing CI, it seems to be just timeouts... over a doc update?

@tniessen

This comment has been minimized.

Copy link
Member

tniessen commented Mar 22, 2020

Restarted.

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Mar 29, 2020

Landed in 154d4e5

@addaleax addaleax closed this Mar 29, 2020
addaleax added a commit that referenced this pull request Mar 29, 2020
PR-URL: #32340
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax added a commit that referenced this pull request Mar 30, 2020
PR-URL: #32340
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.