New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to npm 3.3.6 #3310

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@iarna
Member

iarna commented Oct 10, 2015

This is the big npm@3 integration. 3.3.6 is the version that fixes the major speed regression.

This will require #3308 to land first for tests to pass.

As you are all aware, all kinds of stuff has changed. The changelog for this release in particular is here:

https://github.com/npm/npm/releases/tag/v3.3.6

And the original changelog for 3.0.0 is here:

https://github.com/npm/npm/releases/tag/v3.0.0

r: @Fishrock123
r: @chrisdickinson

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Oct 10, 2015

Member

@iarna could you re-do this now that aff3acf has landed? Thanks!

Member

Fishrock123 commented Oct 10, 2015

@iarna could you re-do this now that aff3acf has landed? Thanks!

@Fishrock123 Fishrock123 added the npm label Oct 10, 2015

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Oct 14, 2015

Member
Jeremiahs-MacBook-Pro:node Jeremiah$ curl -L https://github.com/nodejs/node/pull/3310.patch | git am --whitespace=fix
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   138    0   138    0     0    208      0 --:--:-- --:--:-- --:--:--   208
100 10.1M    0 10.1M    0     0   307k      0 --:--:--  0:00:33 --:--:--  296k
Applying: deps: upgrade to npm 3.3.6
/Users/Jeremiah/documents/node/.git/rebase-apply/patch:9201: trailing whitespace.
default will only publish internally. 
/Users/Jeremiah/documents/node/.git/rebase-apply/patch:32371: trailing whitespace.
Developer, works on packages they are given access to\.  
/Users/Jeremiah/documents/node/.git/rebase-apply/patch:32380: trailing whitespace.
Grant access:  
/Users/Jeremiah/documents/node/.git/rebase-apply/patch:32398: trailing whitespace.
default will only publish internally\. 
/Users/Jeremiah/documents/node/.git/rebase-apply/patch:33417: trailing whitespace.
thing as an optional argument. 
warning: squelched 518 whitespace errors
warning: 443 lines applied after fixing whitespace errors.

@iarna could you please make sure your git config has core.whitespace=fix? Thanks. :)

Member

Fishrock123 commented Oct 14, 2015

Jeremiahs-MacBook-Pro:node Jeremiah$ curl -L https://github.com/nodejs/node/pull/3310.patch | git am --whitespace=fix
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   138    0   138    0     0    208      0 --:--:-- --:--:-- --:--:--   208
100 10.1M    0 10.1M    0     0   307k      0 --:--:--  0:00:33 --:--:--  296k
Applying: deps: upgrade to npm 3.3.6
/Users/Jeremiah/documents/node/.git/rebase-apply/patch:9201: trailing whitespace.
default will only publish internally. 
/Users/Jeremiah/documents/node/.git/rebase-apply/patch:32371: trailing whitespace.
Developer, works on packages they are given access to\.  
/Users/Jeremiah/documents/node/.git/rebase-apply/patch:32380: trailing whitespace.
Grant access:  
/Users/Jeremiah/documents/node/.git/rebase-apply/patch:32398: trailing whitespace.
default will only publish internally\. 
/Users/Jeremiah/documents/node/.git/rebase-apply/patch:33417: trailing whitespace.
thing as an optional argument. 
warning: squelched 518 whitespace errors
warning: 443 lines applied after fixing whitespace errors.

@iarna could you please make sure your git config has core.whitespace=fix? Thanks. :)

@iarna

This comment has been minimized.

Show comment
Hide comment
@iarna

iarna Oct 14, 2015

Member

humm, it does and rebasing with whitespace fixes is a part of our process. And the test suite breaks if there's whitespace errors.

Member

iarna commented Oct 14, 2015

humm, it does and rebasing with whitespace fixes is a part of our process. And the test suite breaks if there's whitespace errors.

@iarna

This comment has been minimized.

Show comment
Hide comment
@iarna

iarna Oct 14, 2015

Member

Looks like... something in a readme or changelog... well whatever, I'll figure out exactly why that happened and make sure it doesn't again. =D

Member

iarna commented Oct 14, 2015

Looks like... something in a readme or changelog... well whatever, I'll figure out exactly why that happened and make sure it doesn't again. =D

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Oct 16, 2015

Member

@iarna could you update this to the latest version today? Also if you then float the changes to pass on the execPath onto npm, and tone down the test-npm changes in #3308 to what is necessary with the npm PR (I think just calling what test and test-npm call without using run-script), then I think this should be good to go. :)

Member

Fishrock123 commented Oct 16, 2015

@iarna could you update this to the latest version today? Also if you then float the changes to pass on the execPath onto npm, and tone down the test-npm changes in #3308 to what is necessary with the npm PR (I think just calling what test and test-npm call without using run-script), then I think this should be good to go. :)

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Oct 19, 2015

Member

ping @iarna, we'd like to have this in the v5 release this week. :)

Member

Fishrock123 commented Oct 19, 2015

ping @iarna, we'd like to have this in the v5 release this week. :)

@iarna

This comment has been minimized.

Show comment
Hide comment
@iarna

iarna Oct 19, 2015

Member

I was out of town (and away from Internet) Friday, Saturday and Sunday. I'll update today. =)

Just to be clear though, the changes in #3308 are needed as is with the latest npm version. It'll be (at least) two weeks before the changes from the PR are in a stable npm release.

Are you asking that I apply that patch to the PR of last week's latest release? (I'm happy to do that until it lands in npm proper, if that's your preferred approach ¯\_(ツ)_/¯)

Member

iarna commented Oct 19, 2015

I was out of town (and away from Internet) Friday, Saturday and Sunday. I'll update today. =)

Just to be clear though, the changes in #3308 are needed as is with the latest npm version. It'll be (at least) two weeks before the changes from the PR are in a stable npm release.

Are you asking that I apply that patch to the PR of last week's latest release? (I'm happy to do that until it lands in npm proper, if that's your preferred approach ¯\_(ツ)_/¯)

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Oct 20, 2015

Member

Hmm, maybe that's not best. I'm not sure, so let's just do it in tools like the original approach. LGTM if this is updated to 3.3.8

Member

Fishrock123 commented Oct 20, 2015

Hmm, maybe that's not best. I'm not sure, so let's just do it in tools like the original approach. LGTM if this is updated to 3.3.8

@rvagg rvagg added this to the 5.0.0 milestone Oct 21, 2015

@rvagg

This comment has been minimized.

Show comment
Hide comment
@rvagg

rvagg Oct 21, 2015

Member

Added to the 5.0.0 milestone

Member

rvagg commented Oct 21, 2015

Added to the 5.0.0 milestone

@rvagg rvagg referenced this pull request Oct 21, 2015

Closed

v5.0.0 Planning & Checklist #3397

13 of 13 tasks complete
@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Oct 22, 2015

Member

@iarna ... I'll take care of the rest of the fixes, but could you please update this to npm 3.3.8? (latest stable?)

Member

Fishrock123 commented Oct 22, 2015

@iarna ... I'll take care of the rest of the fixes, but could you please update this to npm 3.3.8? (latest stable?)

Fishrock123 added a commit that referenced this pull request Oct 22, 2015

deps: upgrade npm to 3.3.6
PR-URL: #3310
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Oct 22, 2015

Member

Thanks, landed in 41923c0 :)

Member

Fishrock123 commented Oct 22, 2015

Thanks, landed in 41923c0 :)

rvagg added a commit that referenced this pull request Oct 26, 2015

deps: upgrade npm to 3.3.6
PR-URL: #3310
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

rvagg added a commit to rvagg/io.js that referenced this pull request Oct 29, 2015

2015-10-29, Version 5.0.0 (Stable)
Notable changes:

* buffer: (Breaking) Removed both 'raw' and 'raws' encoding types from Buffer,
  these have been deprecated for a long time (Sakthipriyan Vairamani) #2859.
* console: (Breaking) Values reported by console.time() now have 3 decimals of
  accuracy added (Michaël Zasso) #3166.
* fs:
  - fs.readFile*(), fs.writeFile*(), and fs.appendFile*() now also accept a file
    descriptor as their first argument (Johannes Wüller) #3163.
  - (Breaking) In fs.readFile(), if an encoding is specified and the internal
    toString() fails the error is no longer thrown but is passed to the callback
    (Evan Lucas) #3485.
  - (Breaking) In fs.read() (using the fs.read(fd, length, position, encoding,
    callback) form), if the internal toString() fails the error is no longer
    thrown but is passed to the callback (Evan Lucas) #3503.
* http:
  - Fixed a bug where pipelined http requests would stall (Fedor Indutny) #3342.
  - (Breaking) When parsing HTTP, don't add duplicates of the following headers:
    Retry-After, ETag, Last-Modified, Server, Age, Expires. This is in addition
    to the following headers which already block duplicates: Content-Type,
    Content-Length, User-Agent, Referer, Host, Authorization,
    Proxy-Authorization, If-Modified-Since, If-Unmodified-Since, From, Location,
    Max-Forwards (James M Snell) #3090.
  - (Breaking) The callback argument to OutgoingMessage#setTimeout() must be a
    function or a TypeError is thrown (James M Snell) #3090.
  - (Breaking) HTTP methods and header names must now conform to the RFC 2616
    "token" rule, a list of allowed characters that excludes control characters
    and a number of separator characters. Specifically, methods and header names
    must now match /^[a-zA-Z0-9_!#$%&'*+.^`|~-]+$/ or a TypeError will be thrown
    (James M Snell) #2526.
* node:
  - (Breaking) Deprecated the _linklist module (Rich Trott) #3078.
  - (Breaking) Removed require.paths and require.registerExtension(), both had
    been previously set to throw Error when accessed
    (Sakthipriyan Vairamani) #2922.
* npm: Upgraded to version 3.3.6 from 2.14.7, see
  https://github.com/npm/npm/releases/tag/v3.3.6 for more details. This is a
  major version bump for npm and it has seen a significant amount of change.
  Please see the original npm v3.0.0 release notes for a list of major changes
  (Rebecca Turner) #3310.
* src: (Breaking) Bumped NODE_MODULE_VERSION to 47 from 46, this is necessary
  due to the V8 upgrade. Native add-ons will need to be recompiled
  (Rod Vagg) #3400.
* timers: Attempt to reuse the timer handle for setTimeout().unref(). This fixes
  a long-standing known issue where unrefed timers would perviously hold
  beforeExit open (Fedor Indutny) #3407.
* tls:
  - Added ALPN Support (Shigeki Ohtsu) #2564.
  - TLS options can now be passed in an object to createSecurePair()
    (Коренберг Марк) #2441.
  - (Breaking) The default minimum DH key size for tls.connect() is now 1024
    bits and a warning is shown when DH key size is less than 2048 bits. This a security consideration to prevent "logjam" attacks. A new minDHSize TLS
    option can be used to override the default. (Shigeki Ohtsu) #1831.
* util:
  - (Breaking) util.p() was deprecated for years, and has now been removed
    (Wyatt Preul) #3432.
  - (Breaking) util.inherits() can now work with ES6 classes. This is considered
    a breaking change because of potential subtle side-effects caused by a
    change from directly reassigning the prototype of the constructor using
    `ctor.prototype = Object.create(superCtor.prototype, { constructor: { ... } })`
    to using `Object.setPrototypeOf(ctor.prototype, superCtor.prototype)`
    (Michaël Zasso) #3455.
* v8: (Breaking) Upgraded to 4.6.85.25 from 4.5.103.35 (Ali Ijaz Sheikh) #3351.
  - Implements the spread operator, see
    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator
    for further information.
  - Implements new.target, see
    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target
    for further information.
* zlib: Decompression now throws on truncated input (e.g. unexpected end of
  file) (Yuval Brik) #2595.

PR-URL: nodejs#3466

rvagg added a commit that referenced this pull request Oct 29, 2015

2015-10-29, Version 5.0.0 (Stable)
Notable changes:

* buffer: (Breaking) Removed both 'raw' and 'raws' encoding types from Buffer,
  these have been deprecated for a long time (Sakthipriyan Vairamani) #2859.
* console: (Breaking) Values reported by console.time() now have 3 decimals of
  accuracy added (Michaël Zasso) #3166.
* fs:
  - fs.readFile*(), fs.writeFile*(), and fs.appendFile*() now also accept a file
    descriptor as their first argument (Johannes Wüller) #3163.
  - (Breaking) In fs.readFile(), if an encoding is specified and the internal
    toString() fails the error is no longer thrown but is passed to the callback
    (Evan Lucas) #3485.
  - (Breaking) In fs.read() (using the fs.read(fd, length, position, encoding,
    callback) form), if the internal toString() fails the error is no longer
    thrown but is passed to the callback (Evan Lucas) #3503.
* http:
  - Fixed a bug where pipelined http requests would stall (Fedor Indutny) #3342.
  - (Breaking) When parsing HTTP, don't add duplicates of the following headers:
    Retry-After, ETag, Last-Modified, Server, Age, Expires. This is in addition
    to the following headers which already block duplicates: Content-Type,
    Content-Length, User-Agent, Referer, Host, Authorization,
    Proxy-Authorization, If-Modified-Since, If-Unmodified-Since, From, Location,
    Max-Forwards (James M Snell) #3090.
  - (Breaking) The callback argument to OutgoingMessage#setTimeout() must be a
    function or a TypeError is thrown (James M Snell) #3090.
  - (Breaking) HTTP methods and header names must now conform to the RFC 2616
    "token" rule, a list of allowed characters that excludes control characters
    and a number of separator characters. Specifically, methods and header names
    must now match /^[a-zA-Z0-9_!#$%&'*+.^`|~-]+$/ or a TypeError will be thrown
    (James M Snell) #2526.
* node:
  - (Breaking) Deprecated the _linklist module (Rich Trott) #3078.
  - (Breaking) Removed require.paths and require.registerExtension(), both had
    been previously set to throw Error when accessed
    (Sakthipriyan Vairamani) #2922.
* npm: Upgraded to version 3.3.6 from 2.14.7, see
  https://github.com/npm/npm/releases/tag/v3.3.6 for more details. This is a
  major version bump for npm and it has seen a significant amount of change.
  Please see the original npm v3.0.0 release notes for a list of major changes
  (Rebecca Turner) #3310.
* src: (Breaking) Bumped NODE_MODULE_VERSION to 47 from 46, this is necessary
  due to the V8 upgrade. Native add-ons will need to be recompiled
  (Rod Vagg) #3400.
* timers: Attempt to reuse the timer handle for setTimeout().unref(). This fixes
  a long-standing known issue where unrefed timers would perviously hold
  beforeExit open (Fedor Indutny) #3407.
* tls:
  - Added ALPN Support (Shigeki Ohtsu) #2564.
  - TLS options can now be passed in an object to createSecurePair()
    (Коренберг Марк) #2441.
  - (Breaking) The default minimum DH key size for tls.connect() is now 1024
    bits and a warning is shown when DH key size is less than 2048 bits. This a security consideration to prevent "logjam" attacks. A new minDHSize TLS
    option can be used to override the default. (Shigeki Ohtsu) #1831.
* util:
  - (Breaking) util.p() was deprecated for years, and has now been removed
    (Wyatt Preul) #3432.
  - (Breaking) util.inherits() can now work with ES6 classes. This is considered
    a breaking change because of potential subtle side-effects caused by a
    change from directly reassigning the prototype of the constructor using
    `ctor.prototype = Object.create(superCtor.prototype, { constructor: { ... } })`
    to using `Object.setPrototypeOf(ctor.prototype, superCtor.prototype)`
    (Michaël Zasso) #3455.
* v8: (Breaking) Upgraded to 4.6.85.25 from 4.5.103.35 (Ali Ijaz Sheikh) #3351.
  - Implements the spread operator, see
    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator
    for further information.
  - Implements new.target, see
    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target
    for further information.
* zlib: Decompression now throws on truncated input (e.g. unexpected end of
  file) (Yuval Brik) #2595.

PR-URL: #3466

@rvagg rvagg referenced this pull request Dec 17, 2015

Closed

Release 4.2.4 Planning #4321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment