Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Consistent error messages in all modules #3374
I'm sure they can. How about something like this?
Rule 2 is inconsistent in this PR, btw. But we could also omit the dot. Which style is prefered?
We established some time back that "breaking tests" !== "breaking code/changes." The exact text of an error message is no guaranteed by the API, only that an error will exist (or throw). This is a perfect example, while some tests may break the code those tests are testing is not actually broken by the change.