Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mark ECMAScript modules implementation as stable #35781

Closed
wants to merge 1 commit into from

Conversation

@guybedford
Copy link
Contributor

@guybedford guybedford commented Oct 23, 2020

Per discussion at the last meeting this is a PR to mark the entire ECMAScript modules implementation as stable while keeping the individual subfeatures unstable as appropriate.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Oct 23, 2020

Review requested:

@guybedford guybedford changed the title doc: mark modules implementation as stable doc: mark ECMAScript modules implementation as stable Oct 23, 2020
Copy link
Member

@MylesBorins MylesBorins left a comment

As mentioned in the meeting I would like to see the commonjs named exports bake a bit longer before landing this.

Thoughts?

doc/api/esm.md Outdated Show resolved Hide resolved
@guybedford
Copy link
Contributor Author

@guybedford guybedford commented Oct 23, 2020

My main reason for posting this now was that it would be nice to include in the 12 backport process, since the two milestones here go together in my mind.

@guybedford
Copy link
Contributor Author

@guybedford guybedford commented Oct 23, 2020

I'm totally fine with delaying this explicit "announcement" though too. It would be good to define what we mean by settled as well.

doc/api/esm.md Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

lgtm

Copy link
Member

@benjamingr benjamingr left a comment

Good job @nodejs/modules-active-members !!!

I know this was a long and hard journey.

@Trott
Trott approved these changes Oct 24, 2020
@targos
targos approved these changes Oct 24, 2020
Copy link
Member

@MylesBorins MylesBorins left a comment

Marking request changes to make it explicit that I want to see CJS named export detection bake in a release more before we flip the bit to mark this stable.

I'd like to see at least another 3 - 4 weeks.

@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Nov 9, 2020

We have the latest implementation slated to land in 12.20.0 on Novmber 24th. How do folks feel about calling the implementation stable for that date?

@aduh95
aduh95 approved these changes Nov 9, 2020
@targos
Copy link
Member

@targos targos commented Nov 10, 2020

What about v14.x?

@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Nov 10, 2020

@targos I feel like we can mark stable on 14.x in the next semver minor. Thoughts?

@targos
Copy link
Member

@targos targos commented Nov 10, 2020

Yes, but I think it would be nice to schedule it close to the v12.x release. Imo it would be very confusing if v12 had more advanced features than v14 during multiple months

@guybedford
Copy link
Contributor Author

@guybedford guybedford commented Nov 10, 2020

For 14.x do we need to wait for semver minor? Since the implementation is already in place there it could just be like an unflagging.

@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Nov 10, 2020

we can land the updates without marking stale.

@guybedford guybedford force-pushed the stabilize-modules branch from 3612dcb to 49a3d17 Nov 15, 2020
@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Nov 18, 2020

It dawned on me that we might want this stabilization to go out next week. As such I've gone ahead and approved this PR, so it can get picked up in next weeks release. Since there are no objection to landing by anyone else I'll go ahead and land this momentarily.

@MylesBorins MylesBorins force-pushed the stabilize-modules branch from 49a3d17 to b4758ff Nov 18, 2020
MylesBorins added a commit to MylesBorins/TSC that referenced this pull request Nov 18, 2020
After many years of work we are marking ESM in Node.js as stable
and sunsetting the Modules Team. Some high level next steps

* Mark modules as stable in core
* Review remaining open issues in nodejs/modules and close / transfer
* Simplify team structure and prune inactive team members

Refs: nodejs/node#35781
Refs: nodejs/modules#567
Refs: https://github.com/orgs/nodejs/teams/modules/discussions/8
MylesBorins added a commit that referenced this pull request Nov 18, 2020
PR-URL: #35781
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Nov 18, 2020

Landed in 73ea670

@watilde
Copy link
Member

@watilde watilde commented Nov 19, 2020

Great job! 🚀

@guybedford you might want to delete the branch from upstream repository

@guybedford guybedford deleted the stabilize-modules branch Nov 19, 2020
@mreinstein
Copy link

@mreinstein mreinstein commented Nov 19, 2020

Thank you thank you thank you thank you!

cjihrig added a commit to cjihrig/node that referenced this pull request Nov 22, 2020
PR-URL: nodejs#35781
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
codebytere added a commit that referenced this pull request Nov 22, 2020
PR-URL: #35781
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
@codebytere codebytere mentioned this pull request Nov 22, 2020
mhdawson pushed a commit to nodejs/TSC that referenced this pull request Nov 23, 2020
* strategic initiatives: mark modules as complete

After many years of work we are marking ESM in Node.js as stable
and sunsetting the Modules Team. Some high level next steps

* Mark modules as stable in core
* Review remaining open issues in nodejs/modules and close / transfer
* Simplify team structure and prune inactive team members

Refs: nodejs/node#35781
Refs: nodejs/modules#567
Refs: https://github.com/orgs/nodejs/teams/modules/discussions/8
@MylesBorins MylesBorins mentioned this pull request Nov 24, 2020
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.