Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: API doc spkac fix #3614

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@jas-
Copy link
Contributor

commented Oct 31, 2015

Fix regarding description of the following functions:

Certificate.exportPublicKey(spkac)
Certificate.exportChallenge(spkac)

The descriptions were applied incorrectly.

crypto: API doc spkac fix
Fix regarding description of the following functions:

Certificate.exportPublicKey(spkac)
Certificate.exportChallenge(spkac)

The descriptions were applied incorrectly.

@mscdex mscdex added crypto doc labels Oct 31, 2015

bnoordhuis added a commit that referenced this pull request Nov 1, 2015

doc: fix crypto spkac function descriptions
Fix regarding description of the following functions:

Certificate.exportPublicKey(spkac)
Certificate.exportChallenge(spkac)

The descriptions were applied incorrectly.

PR-URL: #3614
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Nov 1, 2015

Thanks, landed in 9e3aa45. I used your full name ("Author" originally was "jas-") and I took the liberty of rewriting the first line of the commit log, hope you don't mind; changes to doc/ usually get the doc: prefix.

@bnoordhuis bnoordhuis closed this Nov 1, 2015

@jas-

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2015

Noted, thanks.

rvagg added a commit that referenced this pull request Nov 7, 2015

doc: fix crypto spkac function descriptions
Fix regarding description of the following functions:

Certificate.exportPublicKey(spkac)
Certificate.exportChallenge(spkac)

The descriptions were applied incorrectly.

PR-URL: #3614
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@Fishrock123 Fishrock123 referenced this pull request Nov 11, 2015

Merged

Propose v5.1.0 #3736

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Nov 16, 2015

landed in v4.x-staging as b3b55a5

@rvagg rvagg referenced this pull request Nov 17, 2015

Closed

v4.2.2+1 commit candidates #57

mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Nov 17, 2015

doc: fix crypto spkac function descriptions
Fix regarding description of the following functions:

Certificate.exportPublicKey(spkac)
Certificate.exportChallenge(spkac)

The descriptions were applied incorrectly.

PR-URL: nodejs#3614
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

rvagg added a commit that referenced this pull request Dec 4, 2015

doc: fix crypto spkac function descriptions
Fix regarding description of the following functions:

Certificate.exportPublicKey(spkac)
Certificate.exportChallenge(spkac)

The descriptions were applied incorrectly.

PR-URL: #3614
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@jasnell jasnell referenced this pull request Dec 17, 2015

Closed

Release 4.2.4 Planning #4321

jasnell added a commit that referenced this pull request Dec 17, 2015

doc: fix crypto spkac function descriptions
Fix regarding description of the following functions:

Certificate.exportPublicKey(spkac)
Certificate.exportChallenge(spkac)

The descriptions were applied incorrectly.

PR-URL: #3614
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

jasnell added a commit that referenced this pull request Dec 23, 2015

doc: fix crypto spkac function descriptions
Fix regarding description of the following functions:

Certificate.exportPublicKey(spkac)
Certificate.exportChallenge(spkac)

The descriptions were applied incorrectly.

PR-URL: #3614
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.