Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: refactor to use primordials instead of Array#reduce #36392

Closed
wants to merge 1 commit into from

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 4, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
targos
targos approved these changes Dec 5, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Dec 5, 2020

danbev added a commit that referenced this issue Dec 7, 2020
PR-URL: #36392
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@danbev
Copy link
Member

@danbev danbev commented Dec 7, 2020

Landed in ff048bd.

@danbev danbev closed this Dec 7, 2020
@aduh95 aduh95 deleted the buffer-primordials branch Dec 7, 2020
danielleadams added a commit that referenced this issue Dec 7, 2020
PR-URL: #36392
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
cjihrig added a commit to cjihrig/node that referenced this issue Dec 8, 2020
PR-URL: nodejs#36392
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos added a commit that referenced this issue May 16, 2021
PR-URL: #36392
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos added a commit that referenced this issue Jun 11, 2021
PR-URL: #36392
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants