Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: use regexp instead of str.split().join() #3689

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@hellopao
Copy link
Contributor

commented Nov 6, 2015

No description provided.

@Fishrock123 Fishrock123 added the util label Nov 6, 2015

@Fishrock123

This comment has been minimized.

Copy link
Member

commented Nov 6, 2015

LGTM, looks like this was ancient code.

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2015

LGTM

1 similar comment
@jasnell

This comment has been minimized.

Copy link
Member

commented Nov 6, 2015

LGTM

str = str.split('\n').map(function(line) {
return ' ' + line;
}).join('\n').substr(2);
str = str.replace(/\n/g,'\n ');

This comment has been minimized.

Copy link
@jasnell

jasnell Nov 6, 2015

Member

minor linting issue... need to put a space after the comma in param lists. I'll fix that when landing tho.

jasnell added a commit that referenced this pull request Nov 6, 2015

util: use regexp instead of str.replace().join()
PR-URL: #3689
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Nov 6, 2015

Landed in 02a44e0

@jasnell jasnell closed this Nov 6, 2015

rvagg added a commit that referenced this pull request Nov 7, 2015

util: use regexp instead of str.replace().join()
PR-URL: #3689
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@Fishrock123 Fishrock123 referenced this pull request Nov 11, 2015

Merged

Propose v5.1.0 #3736

MylesBorins added a commit that referenced this pull request Nov 17, 2015

util: use regexp instead of str.replace().join()
PR-URL: #3689
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Nov 17, 2015

landed in v4.x-staging in 1064eb6

@rvagg rvagg referenced this pull request Nov 17, 2015

Closed

v4.2.2+1 commit candidates #57

rvagg added a commit that referenced this pull request Dec 4, 2015

util: use regexp instead of str.replace().join()
PR-URL: #3689
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request Dec 17, 2015

Closed

Release 4.2.4 Planning #4321

jasnell added a commit that referenced this pull request Dec 17, 2015

util: use regexp instead of str.replace().join()
PR-URL: #3689
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request Dec 23, 2015

util: use regexp instead of str.replace().join()
PR-URL: #3689
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.