test: fix flaky test-fs-promises-file-handle-read #37371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
flaky-test
aduh95
approved these changes
Feb 15, 2021
|
Stress test on master on a Pi 3 shows 7 failures in 100 runs. Stress test on this PR on a Pi 3 shows 0 failures in 100 runs. |
targos
approved these changes
Feb 15, 2021
RaisinTen
approved these changes
Feb 15, 2021
|
We could add this in the commit message too: |
jasnell
approved these changes
Feb 15, 2021
tmpdir.refresh() cannot be called multiple times reliably on Raspberry Pi in CI because NFS might optimistically report a path as removed before it actually is. At least, that's what I think is going on. Anyway, tmpdir.refresh() is generally designed to be called once, so let's just call it once. PR-URL: nodejs#37371 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 41516b9 |
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
tmpdir.refresh() cannot be called multiple times reliably on Raspberry Pi in CI because NFS might optimistically report a path as removed before it actually is. At least, that's what I think is going on. Anyway, tmpdir.refresh() is generally designed to be called once, so let's just call it once. PR-URL: #37371 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmpdir.refresh() cannot be called multiple times reliably on Raspberry
Pi in CI because NFS might optimistically report a path as
removed before it actually is. At least, that's what I think is going
on. Anyway, tmpdir.refresh() is generally designed to be called once,
so let's just call it once.