Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib,test: remove publicly exposed freelist #3738

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@cjihrig
Copy link
Contributor

commented Nov 10, 2015

The freelist module was deprecated in io.js and moved to an internal module. This commit removes public access to freelist, while leaving the internal module, which is still in use.

This was discussed in #569, and should be able to go into v6.

lib,test: remove publicly exposed freelist
The freelist module was deprecated in io.js and moved to an
internal module. This commit removes public access to freelist,
while leaving the internal module, which is still in use.

@mscdex mscdex added the lib / src label Nov 10, 2015

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Nov 10, 2015

LGTM. Suggestion: add the semver-major label?

@thefourtheye

This comment has been minimized.

Copy link
Contributor

commented Nov 10, 2015

LGTM

1 similar comment
@targos

This comment has been minimized.

Copy link
Member

commented Nov 10, 2015

LGTM

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2015

cjihrig added a commit that referenced this pull request Nov 11, 2015

lib,test: remove publicly exposed freelist
The freelist module was deprecated in io.js and moved to an
internal module. This commit removes public access to freelist,
while leaving the internal module, which is still in use.

Fixes: #569
PR-URL: #3738
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2015

Landed in b70dc67

@cjihrig cjihrig closed this Nov 11, 2015

@cjihrig cjihrig deleted the cjihrig:freelist branch Nov 11, 2015

@jasnell jasnell referenced this pull request Mar 17, 2016

Closed

Planning for v6 #5766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.