net: fix typo #38127
Closed
net: fix typo #38127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SocketAddress.prototype.construtor` -> `SocketAddress.prototype.constructor`. Fixes: nodejs#38125
aduh95
approved these changes
Apr 7, 2021
This comment has been minimized.
This comment has been minimized.
aduh95
added
author ready
|
fast-track? |
This comment has been minimized.
This comment has been minimized.
tniessen
approved these changes
Apr 7, 2021
ZYSzys
approved these changes
Apr 7, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen
approved these changes
Apr 7, 2021
jasnell
approved these changes
Apr 7, 2021
marsonya
approved these changes
Apr 7, 2021
addaleax
approved these changes
Apr 7, 2021
cjihrig
approved these changes
Apr 8, 2021
VoltrexKeyva
approved these changes
Apr 8, 2021
Lxxyx
approved these changes
Apr 8, 2021
aduh95
pushed a commit
that referenced
this pull request
Apr 8, 2021
`construtor` -> `constructor`. Fixes: #38125 PR-URL: #38127 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
|
Landed in 7869761 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SocketAddress.prototype.construtor->SocketAddress.prototype.constructor.Fixes: #38125