Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: validate ticket keys buffer #38308

Merged
merged 1 commit into from Apr 23, 2021
Merged

tls: validate ticket keys buffer #38308

merged 1 commit into from Apr 23, 2021

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 20, 2021

Fixes: #38305

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

lpinca
lpinca approved these changes Apr 20, 2021
test/parallel/test-tls-ticket-invalid-arg.js Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Apr 20, 2021

Fixes: nodejs#38305

PR-URL: nodejs#38308
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 force-pushed the tls-ticket-keys branch from 661ec67 to e151e90 Apr 23, 2021
@aduh95
Copy link
Contributor Author

@aduh95 aduh95 commented Apr 23, 2021

Landed in e151e90

@aduh95 aduh95 merged commit e151e90 into nodejs:master Apr 23, 2021
30 of 31 checks passed
@aduh95 aduh95 deleted the tls-ticket-keys branch Apr 23, 2021
targos added a commit that referenced this issue Apr 29, 2021
Fixes: #38305

PR-URL: #38308
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 3, 2021
targos added a commit that referenced this issue May 30, 2021
Fixes: #38305

PR-URL: #38308
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this issue Jun 5, 2021
Fixes: #38305

PR-URL: #38308
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this issue Jun 11, 2021
Fixes: #38305

PR-URL: #38308
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants