Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mark process.hrtime() as legacy #38371

Closed
wants to merge 1 commit into from
Closed

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 23, 2021

The docs already states the API is legacy, but we haven't given it the official badge yet:

node/doc/api/process.md

Lines 1421 to 1422 in 8780537

This is the legacy version of [`process.hrtime.bigint()`][]
before `bigint` was introduced in JavaScript.

bengl
bengl approved these changes Apr 23, 2021
@jasnell
Copy link
Member

@jasnell jasnell commented Apr 26, 2021

Landed in 8c99045

@jasnell jasnell closed this Apr 26, 2021
jasnell added a commit that referenced this issue Apr 26, 2021
PR-URL: #38371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@aduh95 aduh95 deleted the hrtime-legacy branch Apr 26, 2021
targos added a commit that referenced this issue Apr 29, 2021
PR-URL: #38371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request May 3, 2021
targos added a commit that referenced this issue May 30, 2021
PR-URL: #38371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos added a commit that referenced this issue Jun 5, 2021
PR-URL: #38371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos added a commit that referenced this issue Jun 5, 2021
PR-URL: #38371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos added a commit that referenced this issue Jun 11, 2021
PR-URL: #38371
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants