Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: add constant declarations for `net` #3950

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@JungMinu
Copy link
Member

commented Nov 21, 2015

Constant declaration for net is omitted in idle_server.js
Add a constant declaration for constant net

@JungMinu JungMinu changed the title benchmark: add a constant type for `net` constant benchmark: add a constant type for constant `net` Nov 21, 2015

@JungMinu JungMinu changed the title benchmark: add a constant type for constant `net` benchmark: add a constant type for `net` Nov 21, 2015

@JungMinu JungMinu changed the title benchmark: add a constant type for `net` benchmark: add a constant declaration for `net` Nov 21, 2015

@tflanagan

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2015

Could you fix the connections and server declarations too?

@targos

This comment has been minimized.

Copy link
Member

commented Nov 21, 2015

Can you add a 'use strict'; statement at the first line ?
It should help to fix this.

@JungMinu

This comment has been minimized.

Copy link
Member Author

commented Nov 21, 2015

@tflanagan @targos Sure, will do :)

benchmark: add a constant declaration for `net`
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

benchmark: add constant declarations for `net`
@JungMinu

This comment has been minimized.

Copy link
Member Author

commented Nov 21, 2015

finished and rebased, Thanks :)

@JungMinu JungMinu changed the title benchmark: add a constant declaration for `net` benchmark: add constant declarations for `net` Nov 21, 2015

@romankl romankl added the benchmark label Nov 21, 2015

@mscdex mscdex added the net label Nov 21, 2015

@Trott Trott force-pushed the nodejs:master branch to 082cc8d Dec 27, 2015

@silverwind

This comment has been minimized.

Copy link
Contributor

commented Jan 27, 2016

LGTM if you still want to land this. We should eventually include benchmark in ESLint.

@jasnell

This comment has been minimized.

Copy link
Member

commented Jan 29, 2016

LGTM

JungMinu added a commit that referenced this pull request Jan 29, 2016

benchmark: add a constant declaration for `net`
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: #3950
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@JungMinu

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2016

Thanks, landed in 4126441

@JungMinu JungMinu closed this Jan 29, 2016

@JungMinu JungMinu deleted the JungMinu:patch-22 branch Jan 29, 2016

rvagg added a commit that referenced this pull request Feb 8, 2016

benchmark: add a constant declaration for `net`
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: #3950
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

MylesBorins added a commit that referenced this pull request Feb 17, 2016

benchmark: add a constant declaration for `net`
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: #3950
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

MylesBorins added a commit that referenced this pull request Feb 18, 2016

benchmark: add a constant declaration for `net`
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: #3950
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

@MylesBorins MylesBorins referenced this pull request Feb 18, 2016

Merged

V4.4.0 proposal #5301

MylesBorins added a commit that referenced this pull request Mar 2, 2016

benchmark: add a constant declaration for `net`
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: #3950
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016

benchmark: add a constant declaration for `net`
Constant declaration for `net` is omitted in `idle_server.js`
Add a constant declaration for constant `net`

PR-URL: nodejs#3950
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.