doc: fix typo in hmac.paramNames default #39766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
J-Human
changed the title
HarshithaKP
approved these changes
Aug 14, 2021
aduh95
approved these changes
Aug 14, 2021
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
HarshithaKP
added
the
author ready
tniessen
approved these changes
Aug 14, 2021
Trott
approved these changes
Aug 14, 2021
Trott
added
commit-queue
Trott
changed the title
cjihrig
approved these changes
Aug 14, 2021
panva
approved these changes
Aug 15, 2021
Trott
changed the title
Trott
changed the title
tniessen
approved these changes
Aug 15, 2021
jasnell
approved these changes
Aug 15, 2021
lpinca
approved these changes
Aug 15, 2021
PR-URL: #39766 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 802ceea |
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39766 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a partially quoted string in a inline code block @ docs, specifically at the WebCrypto documentation for
HmacParams.