Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use platform-based timeout for reliability #4015

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@Trott
Copy link
Member

commented Nov 25, 2015

test-http-client-timeout-with-data fails on Raspberry Pi in CI from time
to time.

Use a platform-based timeout to improve reliability.

test: use platform-based timeout for reliability
test-http-client-timeout-with-data fails on Raspberry Pi in CI from time
to time.

Use a platform-based timeout to improve reliability.

@Trott Trott added test arm labels Nov 25, 2015

@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 25, 2015

@mscdex mscdex added the http label Nov 25, 2015

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Nov 25, 2015

LGTM. CI failures are unrelated (and known) flakes.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 25, 2015

Stress test with current master showing the test failing 5 out of 999 times: https://ci.nodejs.org/job/node-stress-single-test/40/nodes=pi1-raspbian-wheezy/console

Stress test with this fix showing the test failing 0 out of 999 times: https://ci.nodejs.org/job/node-stress-single-test/41/nodes=pi2-raspbian-wheezy/console

@silverwind

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2015

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Nov 26, 2015

test: use platform-based timeout for reliability
test-http-client-timeout-with-data fails on Raspberry Pi in CI from time
to time.

Use a platform-based timeout to improve reliability.

PR-URL: nodejs#4015
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2015

Landed in 20acc60

@Trott Trott closed this Nov 26, 2015

Trott added a commit that referenced this pull request Dec 5, 2015

test: use platform-based timeout for reliability
test-http-client-timeout-with-data fails on Raspberry Pi in CI from time
to time.

Use a platform-based timeout to improve reliability.

PR-URL: #4015
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>

@rvagg rvagg referenced this pull request Dec 17, 2015

Closed

Release 4.2.4 Planning #4321

Trott added a commit that referenced this pull request Dec 29, 2015

test: use platform-based timeout for reliability
test-http-client-timeout-with-data fails on Raspberry Pi in CI from time
to time.

Use a platform-based timeout to improve reliability.

PR-URL: #4015
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>

MylesBorins added a commit that referenced this pull request Jan 19, 2016

test: use platform-based timeout for reliability
test-http-client-timeout-with-data fails on Raspberry Pi in CI from time
to time.

Use a platform-based timeout to improve reliability.

PR-URL: #4015
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>

@MylesBorins MylesBorins referenced this pull request Jan 19, 2016

Merged

V4.2.5 proposal #4768

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016

test: use platform-based timeout for reliability
test-http-client-timeout-with-data fails on Raspberry Pi in CI from time
to time.

Use a platform-based timeout to improve reliability.

PR-URL: nodejs#4015
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>

ryzokuken added a commit to ryzokuken/node that referenced this pull request Mar 6, 2018

test: rename test-regress-nodejsGH-4015
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: nodejs#19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

ryzokuken added a commit to ryzokuken/node that referenced this pull request Mar 6, 2018

test: rename test-regress-nodejsGH-4015
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: nodejs#19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

devsnek added a commit that referenced this pull request Mar 8, 2018

test: rename test-regress-GH-4015
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: #19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: #19161
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

targos added a commit that referenced this pull request Mar 17, 2018

test: rename test-regress-GH-4015
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: #19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: #19161
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

@targos targos referenced this pull request Mar 18, 2018

Merged

v9.9.0 proposal #19428

MylesBorins added a commit that referenced this pull request Mar 20, 2018

test: rename test-regress-GH-4015
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: #19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: #19161
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

MayaLekova added a commit to MayaLekova/node that referenced this pull request May 8, 2018

test: rename test-regress-nodejsGH-4015
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: nodejs#19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: nodejs#19161
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

trivikr pushed a commit to trivikr/node that referenced this pull request Sep 15, 2018

test: rename test-regress-nodejsGH-4015
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: nodejs#19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: nodejs#19161
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.