Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,src: update crypto/README.md #40332

Merged
merged 1 commit into from Oct 7, 2021

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Oct 5, 2021

This is due to #37048.

@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Fast-track has been requested by @Ayase-252. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

Commit Queue failed
- Loading data for nodejs/node/pull/40332
✔  Done loading data for nodejs/node/pull/40332
----------------------------------- PR info ------------------------------------
Title      doc,src: update crypto/README.md (#40332)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:src-crypto-readme-ecdh-ec -> nodejs:master
Labels     fast-track, author ready
Commits    1
 - doc,src: update crypto/README.md
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/40332
Reviewed-By: Luigi Pinca 
Reviewed-By: Filip Skokan 
Reviewed-By: Zijian Liu 
Reviewed-By: Qingyu Deng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40332
Reviewed-By: Luigi Pinca 
Reviewed-By: Filip Skokan 
Reviewed-By: Zijian Liu 
Reviewed-By: Qingyu Deng 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 05 Oct 2021 14:07:49 GMT
   ✔  Approvals: 4
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40332#pullrequestreview-771780799
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/40332#pullrequestreview-771868688
   ✔  - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/40332#pullrequestreview-772216560
   ✔  - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/40332#pullrequestreview-773116029
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub Actions successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1314590958

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 7, 2021
Refs: nodejs#37048

PR-URL: nodejs#40332
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@Trott
Copy link
Member

Trott commented Oct 7, 2021

Landed in 055311a

@Trott Trott merged commit 055311a into nodejs:master Oct 7, 2021
28 checks passed
danielleadams pushed a commit that referenced this pull request Oct 7, 2021
Refs: #37048

PR-URL: #40332
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@tniessen tniessen deleted the src-crypto-readme-ecdh-ec branch October 7, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants