/ node Public
src: ensure V8 initialized before marking milestone #40405
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
When Node.js is started within Electron's environment it doesn't initialize V8, so V8's start time is never set. As a result, Electron logs V8's start time as 0 and it breaks timestamps in the trace log.
This change fixes the issue by adding logic to log V8's start time only when V8 is initialized by Node.js.