Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: s/doNTCallbackX/nextTickCallbackWithXArgs/ #4167

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@rvagg
Copy link
Member

commented Dec 6, 2015

Rename doNTCallback functions for clarity when profiling, these make sense internally but the "NT" in particular is a bit obtuse to be immediately understandable by non-core developers.

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2015

LGTM. It's a style change, but the justification seems worth it.

@mscdex mscdex added the lib / src label Dec 6, 2015

node: s/doNTCallbackX/nextTickCallbackWithXArgs/
Rename doNTCallback functions for clarity when profiling, these make
sense internally but the "NT" in particular is a bit obtuse to be
immediately understandable by non-core developers.

@rvagg rvagg force-pushed the rvagg:rename-do-nt-callback-functions branch to 167c0ab Dec 6, 2015

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Dec 6, 2015

LGTM

1 similar comment
@JungMinu

This comment has been minimized.

Copy link
Member

commented Dec 6, 2015

LGTM

rvagg added a commit that referenced this pull request Dec 7, 2015

node: s/doNTCallbackX/nextTickCallbackWithXArgs/
Rename doNTCallback functions for clarity when profiling, these make
sense internally but the "NT" in particular is a bit obtuse to be
immediately understandable by non-core developers.

PR-URL: #4167
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@JungMinu

This comment has been minimized.

Copy link
Member

commented Dec 7, 2015

Thanks, landed in d2c8ba5

@JungMinu JungMinu closed this Dec 7, 2015

rvagg added a commit that referenced this pull request Dec 8, 2015

node: s/doNTCallbackX/nextTickCallbackWithXArgs/
Rename doNTCallback functions for clarity when profiling, these make
sense internally but the "NT" in particular is a bit obtuse to be
immediately understandable by non-core developers.

PR-URL: #4167
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>

@rvagg rvagg referenced this pull request Dec 17, 2015

Closed

Release 4.2.4 Planning #4321

rvagg added a commit that referenced this pull request Dec 29, 2015

node: s/doNTCallbackX/nextTickCallbackWithXArgs/
Rename doNTCallback functions for clarity when profiling, these make
sense internally but the "NT" in particular is a bit obtuse to be
immediately understandable by non-core developers.

PR-URL: #4167
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>

MylesBorins added a commit that referenced this pull request Jan 19, 2016

node: s/doNTCallbackX/nextTickCallbackWithXArgs/
Rename doNTCallback functions for clarity when profiling, these make
sense internally but the "NT" in particular is a bit obtuse to be
immediately understandable by non-core developers.

PR-URL: #4167
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jan 19, 2016

Merged

V4.2.5 proposal #4768

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016

node: s/doNTCallbackX/nextTickCallbackWithXArgs/
Rename doNTCallback functions for clarity when profiling, these make
sense internally but the "NT" in particular is a bit obtuse to be
immediately understandable by non-core developers.

PR-URL: nodejs#4167
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.