Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation message for ErrnoException #4269

Closed
wants to merge 1 commit into from

Conversation

gagern
Copy link
Contributor

@gagern gagern commented Dec 14, 2015

It seems to me that 75adde0 did a copy & paste mistake here. It doesn't make much sense to me to internally forward to the isolate-aware version of ErrnoException but suggest callees use UVException instead.

@rvagg
Copy link
Member

rvagg commented Dec 14, 2015

LGTM, good catch. I believe this is your first contribution to core, thanks for making the effort and welcome on board!

@indutny pls review

@mscdex mscdex added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 14, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Dec 14, 2015

LGTM

1 similar comment
@indutny
Copy link
Member

indutny commented Dec 14, 2015

LGTM

@Fishrock123 Fishrock123 added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 14, 2015
jasnell pushed a commit that referenced this pull request Dec 14, 2015
Fix copy paste error in deprecation message

PR-URL: #4269
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
@jasnell
Copy link
Member

jasnell commented Dec 14, 2015

Landed in c311b61.

@gagern ... thank you for the fix! one quick note, When I landed the commit I went ahead and fixed up the commit log message. Next time can I ask that you take a look at the commit log style guidelines here: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit

@jasnell jasnell closed this Dec 14, 2015
cjihrig pushed a commit that referenced this pull request Dec 15, 2015
Fix copy paste error in deprecation message

PR-URL: #4269
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
@rvagg rvagg mentioned this pull request Dec 17, 2015
MylesBorins pushed a commit that referenced this pull request Dec 30, 2015
Fix copy paste error in deprecation message

PR-URL: #4269
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Fix copy paste error in deprecation message

PR-URL: #4269
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Fix copy paste error in deprecation message

PR-URL: nodejs#4269
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants