Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update gyp-next to v0.13.0 #44605

Merged
merged 1 commit into from Sep 14, 2022

Conversation

gengjiawen
Copy link
Member

Mainly support iOS ninja build and other sync thing.

@nodejs-github-bot
Copy link
Contributor

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dont-land-on-v14.x PRs that should not land on the v14.x-staging branch and should not be released in v14.x. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Sep 12, 2022
@gengjiawen gengjiawen added request-ci Add this label to start a Jenkins CI on a PR. and removed build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. needs-ci PRs that need a full CI run. gyp Issues and PRs related to the GYP tool and .gyp build files dont-land-on-v14.x PRs that should not land on the v14.x-staging branch and should not be released in v14.x. labels Sep 12, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2022
@nodejs-github-bot
Copy link
Contributor

targos
targos approved these changes Sep 12, 2022
@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit bb0986f into nodejs:main Sep 14, 2022
60 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in bb0986f

@gengjiawen gengjiawen deleted the feat/bump_gyp branch Sep 14, 2022
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
PR-URL: nodejs#44605
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
PR-URL: #44605
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 26, 2022
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
PR-URL: #44605
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
PR-URL: #44605
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@juanarbol
Copy link
Member

This seems to modify some changes made in the OpenSSL v3 update that did not land in the v16.x release branch. Marking this as dont-land-on-v16.x

@juanarbol juanarbol added the dont-land-on-v16.x PRs that should not land on the v16.x-staging branch and should not be released in v16.x. label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-land-on-v16.x PRs that should not land on the v16.x-staging branch and should not be released in v16.x.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants