Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: support dns module in the snapshot #44633

Closed
wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

For the initial iteration, only the default resolver can be serialized/deserialized. If dns.setServers() has been called, we'll preserve the configured DNS servers in the snapshot. We can consider exposing the serialization method if it becomes necessary for user-land snapshots.

For the initial iteration, only the default resolver can be
serialized/deserialized. If `dns.setServers()` has been
called, we'll preserve the configured DNS servers in the snapshot.
We can consider exposing the serialization method if it becomes
necessary for user-land snapshots.
@nodejs-github-bot
Copy link
Contributor

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 14, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgt

@nodejs-github-bot
Copy link
Contributor

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use trailing comma in all the multiline stuff.

lib/internal/dns/utils.js Outdated Show resolved Hide resolved
lib/internal/dns/utils.js Outdated Show resolved Hide resolved
test/common/snapshot.js Outdated Show resolved Hide resolved
test/internet/test-snapshot-dns-resolve.js Outdated Show resolved Hide resolved
test/internet/test-snapshot-dns-lookup.js Outdated Show resolved Hide resolved
test/fixtures/snapshot/dns-resolve.js Outdated Show resolved Hide resolved
test/fixtures/snapshot/dns-lookup.js Outdated Show resolved Hide resolved
test/common/snapshot.js Outdated Show resolved Hide resolved
test/common/snapshot.js Outdated Show resolved Hide resolved
lib/internal/dns/utils.js Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot
Copy link
Contributor

aduh95
aduh95 approved these changes Sep 20, 2022
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

joyeecheung added a commit that referenced this pull request Sep 28, 2022
For the initial iteration, only the default resolver can be
serialized/deserialized. If `dns.setServers()` has been
called, we'll preserve the configured DNS servers in the snapshot.
We can consider exposing the serialization method if it becomes
necessary for user-land snapshots.

PR-URL: #44633
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@joyeecheung
Copy link
Member Author

Landed in 8821860

@juanarbol
Copy link
Member

This depends on #44541; I will mark this as "backport-blocked-v16.x"

@juanarbol juanarbol added the backport-blocked-v16.x PRs that should land on the v16.x-staging branch but are blocked by another PR's pending backport. label Oct 4, 2022
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
For the initial iteration, only the default resolver can be
serialized/deserialized. If `dns.setServers()` has been
called, we'll preserve the configured DNS servers in the snapshot.
We can consider exposing the serialization method if it becomes
necessary for user-land snapshots.

PR-URL: #44633
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
codebytere added a commit to electron/electron that referenced this pull request Nov 21, 2022
jkleinsc added a commit to electron/electron that referenced this pull request Nov 21, 2022
* chore: bump node in DEPS to v18.12.1

* chore: update patches

* chore: add missing <algorithm> include

* src: add detailed embedder process initialization AP

nodejs/node#44121

* chore: update gn build files

* dns: support dns module in the snapshot

nodejs/node#44633

#36118

* src: fix OOB reads in process.title getter

nodejs/node#31633

* chore: fix incorrectly removed patch bit

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-blocked-v16.x PRs that should land on the v16.x-staging branch but are blocked by another PR's pending backport. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants