Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor to await #44689

Conversation

anjanakvellore
Copy link
Contributor

Changes the promises to async/await in
test/parallel/test-debugger-invalid-json.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 16, 2022
@Trott Trott added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 16, 2022
Trott
Trott approved these changes Sep 20, 2022
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 20, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2022
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

Changes the promises to async/await in
test/parallel/test-debugger-invalid-json.
@Trott Trott force-pushed the refactor-test-debugger-invalid-json branch from 780fac5 to 5b4106c Compare September 25, 2022 16:58
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2022
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 29, 2022
@nodejs-github-bot
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/44689
✔  Done loading data for nodejs/node/pull/44689
----------------------------------- PR info ------------------------------------
Title      test: refactor to await (#44689)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     anjanakvellore:refactor-test-debugger-invalid-json -> nodejs:main
Labels     test, code-and-learn, author ready, needs-ci
Commits    1
 - test: use await in test-debugger-invalid-json
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/44689
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44689
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - test: use await in test-debugger-invalid-json
   ℹ  This PR was created on Fri, 16 Sep 2022 21:20:22 GMT
   ✔  Approvals: 1
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44689#pullrequestreview-1113090104
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-09-29T14:14:20Z: https://ci.nodejs.org/job/node-test-pull-request/46940/
- Querying data for job/node-test-pull-request/46940/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3153811990

Trott
Trott approved these changes Sep 29, 2022
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2022
@nodejs-github-bot nodejs-github-bot merged commit 70047b0 into nodejs:main Sep 29, 2022
54 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in 70047b0

@Trott
Copy link
Member

Trott commented Sep 29, 2022

Thanks for the contribution! 🎉

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
Changes the promises to async/await in
test/parallel/test-debugger-invalid-json.

PR-URL: #44689
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants