Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip some binding tests on IBMi PASE #44810

Merged
merged 1 commit into from Oct 2, 2022

Conversation

richardlau
Copy link
Member

IBM i PASE Node.js always links to shared openssl
libraries. Skip recently added OpenSSL addons
tests as we do for other OpenSSL addons tests on
IBM i.

Refs: #31967
Refs: #44148

cc @nodejs/platform-ibmi

IBM i PASE Node.js always links to shared openssl
libraries. Skip recently added OpenSSL addons
tests as we do for other OpenSSL addons tests on
IBM i.

Refs: nodejs#31967
Refs: nodejs#44148
@richardlau richardlau added test Issues and PRs related to the tests. ibm i Issues and PRs related to the IBM i platform. labels Sep 28, 2022
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. labels Sep 28, 2022
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@nodejs-github-bot
Copy link
Contributor

lpinca
lpinca approved these changes Sep 28, 2022
@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 28, 2022
Trott
Trott approved these changes Sep 29, 2022
@richardlau richardlau mentioned this pull request Sep 29, 2022
4 tasks
jasnell
jasnell approved these changes Oct 2, 2022
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit 50aac70 into nodejs:main Oct 2, 2022
62 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in 50aac70

@richardlau richardlau deleted the ibmiaddons branch October 2, 2022 22:45
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
IBM i PASE Node.js always links to shared openssl
libraries. Skip recently added OpenSSL addons
tests as we do for other OpenSSL addons tests on
IBM i.

Refs: #31967
Refs: #44148
PR-URL: #44810
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants