Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,crypto: mark experimental algorithms more visually #44892

Merged
merged 1 commit into from Oct 6, 2022

Conversation

panva
Copy link
Member

@panva panva commented Oct 4, 2022

Similar to #44588 this adds a Stability index color-coded indicator to experimental WebCryptoAPI algorithms' documentation.

🖼️ Dark mode - table Screenshot 2022-10-04 at 14 21 10
🖼️ Light mode - table Screenshot 2022-10-04 at 14 20 14
🖼️ Dark mode - list Screenshot 2022-10-04 at 14 20 56
🖼️ Light mode - list Screenshot 2022-10-04 at 14 20 32

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 4, 2022
@panva panva added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. webcrypto and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 4, 2022
@nodejs nodejs deleted a comment from nodejs-github-bot Oct 4, 2022
@panva
Copy link
Member Author

panva commented Oct 4, 2022

Review requested:

  • @nodejs/crypto
  • @nodejs/documentation

@Trott
Copy link
Member

Trott commented Oct 5, 2022

I pulled these changes in and used a tool to check the resulting HTML for accessibility-related color contrast issues and there weren't any. 👍 Looks good to me.

@panva panva marked this pull request as ready for review October 5, 2022 12:01
@panva panva force-pushed the webcrypto-api-experimental branch from 6534dee to b9d74e0 Compare October 5, 2022 12:01
@panva panva requested a review from Trott October 5, 2022 12:02
@panva panva force-pushed the webcrypto-api-experimental branch from b9d74e0 to 555466e Compare October 5, 2022 12:11
aymen94
aymen94 approved these changes Oct 5, 2022
@aymen94
Copy link
Member

aymen94 commented Oct 5, 2022

LGTM

lpinca
lpinca approved these changes Oct 5, 2022
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 5, 2022
Trott
Trott approved these changes Oct 6, 2022
@Trott
Copy link
Member

Trott commented Oct 6, 2022

FYI for @nodejs/website @nodejs/nodejs-dev in case these kinds of things might affect the website in ways I'm not aware of.

@ovflowd
Copy link
Member

ovflowd commented Oct 6, 2022

For nodejs.dev this change would not create any issues afaik.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2022
@nodejs-github-bot nodejs-github-bot merged commit aacd742 into nodejs:main Oct 6, 2022
17 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in aacd742

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
PR-URL: #44892
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@panva panva deleted the webcrypto-api-experimental branch October 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. webcrypto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants