Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update OpenSSL 3.0.7+quic #45286

Closed
wants to merge 2 commits into from

Conversation

RafaelGSS
Copy link
Member

Updated openssl dep to openssl-3.0.7+quic using the maintenance guide.

Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-November/000241.html

This updates all sources in deps/openssl/openssl by:
    $ git clone git@github.com:quictls/openssl.git
    $ cd openssl
    $ git checkout openssl-3.0.7+quic
    $ cd ../node/deps/openssl
    $ rm -rf openssl
    $ cp -R ../../../openssl openssl
    $ rm -rf openssl/.git* openssl/.travis*
    $ git add --all openssl
    $ git commit openssl
@nodejs-github-bot
Copy link
Contributor

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Nov 2, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

RafaelGSS added a commit to RafaelGSS/node that referenced this pull request Nov 2, 2022
This updates all sources in deps/openssl/openssl by:
    $ git clone git@github.com:quictls/openssl.git
    $ cd openssl
    $ git checkout openssl-3.0.7+quic
    $ cd ../node/deps/openssl
    $ rm -rf openssl
    $ cp -R ../../../openssl openssl
    $ rm -rf openssl/.git* openssl/.travis*
    $ git add --all openssl
    $ git commit openssl

PR-URL: nodejs#45286
RafaelGSS added a commit to RafaelGSS/node that referenced this pull request Nov 2, 2022
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
    $ make -C deps/openssl/config
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/openssl
    $ git commit

PR-URL: nodejs#45286
@richardlau
Copy link
Member

@RafaelGSS 32-bit Windows has failed. Looks like a reoccurrence of #43603 (comment).

After an OpenSSL source update, all the config files need to be
regenerated and committed by:
    $ make -C deps/openssl/config clean
    $ make -C deps/openssl/config
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/openssl
    $ git commit
@RafaelGSS RafaelGSS force-pushed the openssl-3.0.7+quic-main branch from b6394a2 to 766af01 Compare Nov 3, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@RafaelGSS
Copy link
Member Author

@richardlau it seems fixed. @juanarbol you need to cherry-pick it again.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

@BethGriggs
Copy link
Member

Landed in 4124b03...9fb612e

@carboneater
Copy link

carboneater commented Nov 7, 2022

Hello,
Usually, upon merging something that would trigger a new release, the node bot would run some actions to open a new PR at docker-library/official-images

Looks like this hasn't happened as there were no merged PRs for the security release...

Can somebody give the bot a push so the official images can be updated?

Thanks

lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
This updates all sources in deps/openssl/openssl by:
    $ git clone git@github.com:quictls/openssl.git
    $ cd openssl
    $ git checkout openssl-3.0.7+quic
    $ cd ../node/deps/openssl
    $ rm -rf openssl
    $ cp -R ../../../openssl openssl
    $ rm -rf openssl/.git* openssl/.travis*
    $ git add --all openssl
    $ git commit openssl

CVE-ID: CVE-2022-3602, CVE-2022-3786
PR-URL: nodejs#45286
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
    $ make -C deps/openssl/config clean
    $ make -C deps/openssl/config
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/openssl
    $ git commit

CVE-ID: CVE-2022-3602, CVE-2022-3786
PR-URL: nodejs#45286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants