Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: align stdout and std error with and without --test #48057

Closed
wants to merge 2 commits into from
Closed

test_runner: align stdout and std error with and without --test #48057

wants to merge 2 commits into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented May 18, 2023 •
edited

without --test:
image

before:
image

after (now matching running without --test):
image

same behavior with TAP reporter:

image

@MoLow MoLow requested a review from cjihrig May 18, 2023 12:47
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 18, 2023
@cjihrig
Copy link
Contributor

cjihrig commented May 18, 2023

Can you add a test (unless we have an existing test) to confirm that colors are not used if the terminal doesn't support, or colors are explicitly disabled. A test to verify that this only impacts the spec reporter would be nice as well.

@MoLow
Copy link
Member Author

MoLow commented May 18, 2023

Can you add a test (unless we have an existing test) to confirm that colors are not used if the terminal doesn't support, or colors are explicitly disabled.

all the existing snapshot tests assert that, don't they?

A test to verify that this only impacts the spec reporter would be nice as well.

it impacts all reporters, not only spec reporter. if console.log(1) when running node --test-reporter tap test.js outputs 1 colored - adding --test should behave the same way (inside a diagnostic):

image

@MoLow MoLow force-pushed the color_--test branch 4 times, most recently from 98408dc to d0fb5ce Compare May 23, 2023 07:14
@MoLow MoLow added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label May 23, 2023
@MoLow MoLow changed the title test_runner: pass FORCE_COLOR to child process test_runner: align stdout and std error with and without --test May 23, 2023
@MoLow MoLow mentioned this pull request May 23, 2023
Closed
@MoLow MoLow requested review from cjihrig and removed request for cjihrig May 23, 2023 17:01
@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51950/

@MoLow
Copy link
Member Author

MoLow commented May 24, 2023

@cjihrig can you re-approve so I can land with the commit queue?

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2023
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request May 26, 2023
@MoLow @marco-ippolito
test_runner: dont split lines on test:stdout
166629b 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request May 26, 2023
@MoLow @marco-ippolito
test_runner: pass FORCE_COLOR to child process
b969eab 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced May 27, 2023
Open
Open
Open
Open
targos pushed a commit that referenced this pull request May 30, 2023
@MoLow @targos
test_runner: dont split lines on test:stdout
3278542 
PR-URL: #48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2023
@MoLow @targos
test_runner: pass FORCE_COLOR to child process
750d3e8 
PR-URL: #48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions github-actions bot mentioned this pull request May 31, 2023
Open
22 tasks
@targos targos mentioned this pull request Jun 4, 2023
Merged
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 6, 2023
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test_runner: pass FORCE_COLOR to child process
3680f33 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow MoLow added backport-open-v18.x Indicate that the PR has an open backport. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Jul 6, 2023
@MoLow MoLow mentioned this pull request Jul 6, 2023
Closed
MoLow added a commit to MoLow/node that referenced this pull request Jul 9, 2023
@MoLow
test_runner: pass FORCE_COLOR to child process
32178ee 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 9, 2023
@MoLow
test_runner: pass FORCE_COLOR to child process
efaac94 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 9, 2023
@MoLow
test_runner: pass FORCE_COLOR to child process
6bb7c53 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 9, 2023
@MoLow
test_runner: pass FORCE_COLOR to child process
5fb5820 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 9, 2023
@MoLow
test_runner: pass FORCE_COLOR to child process
d628529 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 9, 2023
@MoLow
test_runner: pass FORCE_COLOR to child process
12bb570 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow @danielleadams
test_runner: pass FORCE_COLOR to child process
04eb1f8 
PR-URL: #48057
Backport-PR-URL: #48684
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow @danielleadams
test_runner: dont split lines on test:stdout
d795c0a 
PR-URL: #48057
Backport-PR-URL: #48684
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Jul 12, 2023
@danielleadams danielleadams mentioned this pull request Jul 12, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: dont split lines on test:stdout
91b49b1 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: pass FORCE_COLOR to child process
b02e22f 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: dont split lines on test:stdout
0e736d3 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: pass FORCE_COLOR to child process
3d51afe 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@HinataKah0 HinataKah0 HinataKah0 left review comments

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MoLow @nodejs-github-bot @cjihrig @ljharb @aduh95 @HinataKah0 @danielleadams