-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add atlowChemi to triagers #48104
doc: add atlowChemi to triagers #48104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entry needs to be moved, but other than that, this looks good to me.
👍🏻 I'l let others approve this as we are brothers ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
cc @nodejs/issue-triage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome aboard!
Commit Queue failed- Loading data for nodejs/node/pull/48104 ✔ Done loading data for nodejs/node/pull/48104 ----------------------------------- PR info ------------------------------------ Title doc: add atlowChemi to triagers (#48104) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch atlowChemi:add-atlowChemi-to-triagers -> nodejs:main Labels doc Commits 2 - doc: add atlowChemi to triagers - re-order Committers 1 - atlowChemi PR-URL: https://github.com/nodejs/node/pull/48104 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Rich Trott Reviewed-By: Qingyu Deng Reviewed-By: Darshan Sen Reviewed-By: Daeyeon Jeong Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Feng Yu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48104 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Rich Trott Reviewed-By: Qingyu Deng Reviewed-By: Darshan Sen Reviewed-By: Daeyeon Jeong Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Feng Yu -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 21 May 2023 16:08:49 GMT ✔ Approvals: 8 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435563635 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435564304 ✔ - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435713363 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435794234 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435797533 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/48104#pullrequestreview-1436005936 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48104#pullrequestreview-1444503120 ✔ - Feng Yu (@F3n67u): https://github.com/nodejs/node/pull/48104#pullrequestreview-1444841370 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48104 From https://github.com/nodejs/node * branch refs/pull/48104/merge -> FETCH_HEAD ✔ Fetched commits as 186307a48432..313f80f3a60e -------------------------------------------------------------------------------- Auto-merging README.md [main 9117246235] doc: add atlowChemi to triagers Author: atlowChemi Date: Sun May 21 19:00:00 2023 +0300 1 file changed, 2 insertions(+) Auto-merging README.md [main 86e4513914] re-order Author: atlowChemi Date: Sun May 21 19:31:26 2023 +0300 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/5103062163 |
Landed in 7f6f17e |
PR-URL: #48104 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>
PR-URL: #48104 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>
PR-URL: nodejs#48104 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>
PR-URL: nodejs#48104 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>
PR-URL: nodejs#48104 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>
I recently started contributing to the node project. I am looking forward to getting more involved in the node project, and one day becoming a collaborator 🙏🏽
I have read node's code of conduct, and I will adhere to it