Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add assertion for TLS peer certificate fingerprint #4923

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@lumberj
Copy link

commented Jan 28, 2016

PR-URL: #4923
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

@mscdex mscdex added tls test labels Jan 28, 2016

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Jan 28, 2016

LGTM but can you amend the commit log so it conforms to the guidelines from CONTRIBUTING.md? In particular, it should start with the subsystem (test:).

CI: https://ci.nodejs.org/job/node-test-pull-request/1419/ (currently private because of the upcoming security release.)

@lumberj lumberj force-pushed the lumberj:test-fingerprint branch Jan 29, 2016

@lumberj lumberj changed the title Add assertion for TLS peer certificate fingerprint test: Add assertion for TLS peer certificate fingerprint Jan 29, 2016

@lumberj

This comment has been minimized.

Copy link
Author

commented Jan 29, 2016

Thanks @bnoordhuis. Just updated the commit message

@jasnell

This comment has been minimized.

Copy link
Member

commented Jan 29, 2016

LGTM

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Jan 29, 2016

@lumberj Can you run make lint? The linter is complaining that:

/usr/home/iojs/build/workspace/node-test-linter/test/parallel/test-tls-peer-certificate.js
  41:1  error  Line 41 exceeds the maximum line length of 80  max-len
Alan Cohen
test: Add assertion for TLS peer certificate fingerprint
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@lumberj lumberj force-pushed the lumberj:test-fingerprint branch to 7b61f02 Jan 30, 2016

@lumberj

This comment has been minimized.

Copy link
Author

commented Jan 30, 2016

Thanks, just fixed the lint error.

On Fri, Jan 29, 2016 at 12:36 AM, Ben Noordhuis notifications@github.com
wrote:

@lumberj https://github.com/lumberj Can you run make lint? The linter
is complaining that:

/usr/home/iojs/build/workspace/node-test-linter/test/parallel/test-tls-peer-certificate.js
41:1 error Line 41 exceeds the maximum line length of 80 max-len


Reply to this email directly or view it on GitHub
#4923 (comment).

Alan Cohen
@alan_mit https://twitter.com/intent/user?screen_name=alan_mit

jasnell added a commit that referenced this pull request Feb 1, 2016

test: Add assertion for TLS peer certificate fingerprint
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Feb 1, 2016

Landed in 59fb26c

@jasnell jasnell closed this Feb 1, 2016

rvagg added a commit that referenced this pull request Feb 8, 2016

test: Add assertion for TLS peer certificate fingerprint
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 17, 2016

test: Add assertion for TLS peer certificate fingerprint
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 18, 2016

test: Add assertion for TLS peer certificate fingerprint
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Feb 18, 2016

Merged

V4.4.0 proposal #5301

MylesBorins added a commit that referenced this pull request Mar 2, 2016

test: Add assertion for TLS peer certificate fingerprint
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016

test: Add assertion for TLS peer certificate fingerprint
PR-URL: nodejs#4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.