Fix V8 debugger bug caused by 'use strict' pragma #494

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@sairion
Contributor

sairion commented Jan 18, 2015

This is following-up fix for nodejs/node-v0.x-archive#8973.

It seems like v8's bug status is "fixed", so this bug is going to be automatically fixed when you guys pull,
however I am not sure what is this project's policy (how often V8 src would be pulled from upstream, etc...) is like. Feel free to close if maintainers think this is not needed.

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Jan 18, 2015

Member

@sairion Thanks for bringing it up. I think we need to take the patch from https://codereview.chromium.org/813873007/ because it contains at least one other bug fix. I've asked the V8 people if they can back-port it.

If you can update the PR to that patch, I'll land it. The commit log for floating patches normally starts with 'deps:' and includes a description and a link to the CR. You can find the general style guide for commit logs in CONTRIBUTING.md. Thanks!

Member

bnoordhuis commented Jan 18, 2015

@sairion Thanks for bringing it up. I think we need to take the patch from https://codereview.chromium.org/813873007/ because it contains at least one other bug fix. I've asked the V8 people if they can back-port it.

If you can update the PR to that patch, I'll land it. The commit log for floating patches normally starts with 'deps:' and includes a description and a link to the CR. You can find the general style guide for commit logs in CONTRIBUTING.md. Thanks!

deps: fix V8 debugger bugs
This is following-up fix for https://codereview.chromium.org/813873007/.
This bug currently breaks node-inspector client to work.

PR: #494
@sairion

This comment has been minimized.

Show comment
Hide comment
@sairion

sairion Jan 18, 2015

Contributor

@bnoordhuis OK, rebased and fixed! :)

Contributor

sairion commented Jan 18, 2015

@bnoordhuis OK, rebased and fixed! :)

bnoordhuis added a commit that referenced this pull request Jan 18, 2015

deps: fix V8 debugger bugs
This is following-up fix for https://codereview.chromium.org/813873007/.
This bug currently breaks node-inspector client to work.

PR-URL: #494
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Jan 18, 2015

Member

Much appreciated, Jay. Landed in d566ded, thanks!

Member

bnoordhuis commented Jan 18, 2015

Much appreciated, Jay. Landed in d566ded, thanks!

@bnoordhuis bnoordhuis closed this Jan 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment