Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix V8 debugger bug caused by 'use strict' pragma #494

Closed
wants to merge 1 commit into from

Conversation

sairion
Copy link
Contributor

@sairion sairion commented Jan 18, 2015

This is following-up fix for nodejs/node-v0.x-archive#8973.

It seems like v8's bug status is "fixed", so this bug is going to be automatically fixed when you guys pull,
however I am not sure what is this project's policy (how often V8 src would be pulled from upstream, etc...) is like. Feel free to close if maintainers think this is not needed.

@bnoordhuis
Copy link
Member

@sairion Thanks for bringing it up. I think we need to take the patch from https://codereview.chromium.org/813873007/ because it contains at least one other bug fix. I've asked the V8 people if they can back-port it.

If you can update the PR to that patch, I'll land it. The commit log for floating patches normally starts with 'deps:' and includes a description and a link to the CR. You can find the general style guide for commit logs in CONTRIBUTING.md. Thanks!

This is following-up fix for https://codereview.chromium.org/813873007/.
This bug currently breaks node-inspector client to work.

PR: nodejs#494
@sairion
Copy link
Contributor Author

sairion commented Jan 18, 2015

@bnoordhuis OK, rebased and fixed! :)

bnoordhuis pushed a commit that referenced this pull request Jan 18, 2015
This is following-up fix for https://codereview.chromium.org/813873007/.
This bug currently breaks node-inspector client to work.

PR-URL: #494
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis
Copy link
Member

Much appreciated, Jay. Landed in d566ded, thanks!

@bnoordhuis bnoordhuis closed this Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants