Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix tcp raw benchmarks after internal api change #495

Closed
wants to merge 1 commit into from
Closed

benchmark: fix tcp raw benchmarks after internal api change #495

wants to merge 1 commit into from

Conversation

yosuke-furukawa
Copy link
Member

tcp raw benchmarks are broken. I got assertion failures when benchmark test is executed.

Assertion failed: ((object->InternalFieldCount()) > (0)), function Wrap, file ../src/util-inl.h, line 83.

I found the internal api changes on this commit (819690f).
I think I fixed the benchmarks.

The result is here.

$ ./iojs benchmark/common.js net tcp
net/tcp-raw-c2s.js
net/tcp-raw-c2s.js len=102400 type=utf dur=5: 6
net/tcp-raw-c2s.js len=102400 type=asc dur=5: 11
net/tcp-raw-c2s.js len=102400 type=buf dur=5: 13
net/tcp-raw-c2s.js len=16777216 type=utf dur=5: 5
net/tcp-raw-c2s.js len=16777216 type=asc dur=5: 9
net/tcp-raw-c2s.js len=16777216 type=buf dur=5: 13

net/tcp-raw-pipe.js
net/tcp-raw-pipe.js len=102400 type=utf dur=5: 8
net/tcp-raw-pipe.js len=102400 type=asc dur=5: 11
net/tcp-raw-pipe.js len=102400 type=buf dur=5: 12
net/tcp-raw-pipe.js len=16777216 type=utf dur=5: 7
net/tcp-raw-pipe.js len=16777216 type=asc dur=5: 9
net/tcp-raw-pipe.js len=16777216 type=buf dur=5: 12

net/tcp-raw-s2c.js
net/tcp-raw-s2c.js len=102400 type=utf dur=5: 6
net/tcp-raw-s2c.js len=102400 type=asc dur=5: 11
net/tcp-raw-s2c.js len=102400 type=buf dur=5: 13
net/tcp-raw-s2c.js len=16777216 type=utf dur=5: 4
net/tcp-raw-s2c.js len=16777216 type=asc dur=5: 8
net/tcp-raw-s2c.js len=16777216 type=buf dur=5: 13

@mscdex
Copy link
Contributor

mscdex commented Jan 18, 2015

+1

bnoordhuis pushed a commit that referenced this pull request Jan 18, 2015
Fix up the tcp raw benchmarks after an internal API change.

PR-URL: #495
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis
Copy link
Member

Thanks Yosuke, landed in 3abfb56.

@bnoordhuis bnoordhuis closed this Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants